diff options
author | Alyssa Ross <hi@alyssa.is> | 2020-05-30 18:48:02 +0000 |
---|---|---|
committer | Alyssa Ross <hi@alyssa.is> | 2020-06-02 03:25:34 +0000 |
commit | a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece (patch) | |
tree | 0c88f4d30121baa7234432ad9c91649b845e326c /pkgs/os-specific/linux/chromium-os/vm_protos | |
parent | e72c23ff066a947473ef18973bed07ce192ec3b2 (diff) | |
download | nixpkgs-a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece.tar nixpkgs-a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece.tar.gz nixpkgs-a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece.tar.bz2 nixpkgs-a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece.tar.lz nixpkgs-a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece.tar.xz nixpkgs-a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece.tar.zst nixpkgs-a1f01bb6ca7c14bb2aa14d1930525dd20e0d0ece.zip |
chromiumOSPackages: 81.12871.0.0-rc1 -> 83.13020.0.0-rc1
crosvm now needs the Minijail sources. However, it'll notice that a Minijail package is provided via pkg-config, and then not actually use those sources or build its own Minijail. It would be nice if the Minijail we provide could be the same version as in Chromium OS, which means bringing Minijail under chromiumOSPackages. A couple of backports are no longer required; one to common-mk and one to Linux. A new patch to fix a parallel build failure has been introduced. Message-Id: <20200602005619.31128-1-hi@alyssa.is> Thanks-to: Michael Raskin <7c6f434c@mail.ru> Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com> Tested-by: Cole Helbling <cole.e.helbling@outlook.com>
Diffstat (limited to 'pkgs/os-specific/linux/chromium-os/vm_protos')
-rw-r--r-- | pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch | 39 | ||||
-rw-r--r-- | pkgs/os-specific/linux/chromium-os/vm_protos/default.nix | 2 |
2 files changed, 41 insertions, 0 deletions
diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch b/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch new file mode 100644 index 00000000000..93fa535ac7e --- /dev/null +++ b/pkgs/os-specific/linux/chromium-os/vm_protos/0003-vm_tools-proto-fix-parallel-build.patch @@ -0,0 +1,39 @@ +From dfed9458bf7abc1dc8f33a3e16ee179cde88e4e2 Mon Sep 17 00:00:00 2001 +From: Alyssa Ross <hi@alyssa.is> +Date: Tue, 2 Jun 2020 00:21:08 +0000 +Subject: [PATCH 3/6] vm_tools: proto: fix parallel build + +fuzzer-protos depends on vm-crash-rpcs, but this dependency wasn't +declared, causing build failures like the following: + +[26/52] CXX obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o +FAILED: obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o +c++ -MMD -MF obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Igen/include -I../../common-mk -I/usr/include -Igen -Igen -Igen -Igen -Wall -Wunused -Wno-unused-parameter -Wunreachable-code -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Wimplicit-fallthrough -Werror --sysroot= -fPIE -fvisibility=default -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -pthread -I/nix/store/pjl2q3lny3c18ypqjcv0q3akyq89hg2i-grpc-1.28.1/include -I/nix/store/hya0y6slws66h99njc2yiz02irfv4n62-openssl-1.1.1g-dev/include -I/nix/store/mfpg3sk5vk9rm99hbpmd3dgvxqybd391-protobuf-3.8.0/include -Wno-unreachable-code -std=gnu++14 -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Wno-psabi -c gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc -o obj/out/Release/gen/include/vm_protos/proto_bindings/libfuzzer-protos.fuzzer.grpc.pb.o +In file included from gen/include/vm_protos/proto_bindings/fuzzer.grpc.pb.cc:5: +gen/include/vm_protos/proto_bindings/fuzzer.pb.h:38:10: fatal error: vm_crash.pb.h: No such file or directory + 38 | #include "vm_crash.pb.h" + | ^~~~~~~~~~~~~~~ +compilation terminated. +ninja: build stopped: subcommand failed. + +Reported-by: Cole Helbling <cole.e.helbling@outlook.com> +Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com> +--- + vm_tools/proto/BUILD.gn | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/vm_tools/proto/BUILD.gn b/vm_tools/proto/BUILD.gn +index 713b81853..a25265cab 100644 +--- a/vm_tools/proto/BUILD.gn ++++ b/vm_tools/proto/BUILD.gn +@@ -70,6 +70,7 @@ proto_library("fuzzer-protos") { + deps = [ + ":container-rpcs", + ":tremplin-rpcs", ++ ":vm-crash-rpcs", + ] + sources = [ + "${proto_in_dir}/fuzzer.proto", +-- +2.26.2 + diff --git a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix b/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix index 9b56745e909..9620acb9a3e 100644 --- a/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix +++ b/pkgs/os-specific/linux/chromium-os/vm_protos/default.nix @@ -9,6 +9,8 @@ common-mk { NIX_CFLAGS_COMPILE = [ "-Wno-error=array-bounds" ]; + platform2Patches = [ ./0003-vm_tools-proto-fix-parallel-build.patch ]; + postPatch = '' substituteInPlace common-mk/proto_library.gni \ --replace /usr/bin/grpc_cpp_plugin ${grpc}/bin/grpc_cpp_plugin |