summary refs log tree commit diff
path: root/pkgs/development/tools/misc/itstool
diff options
context:
space:
mode:
authorChuck <chuck@intelligence.org>2019-10-30 17:32:15 -0700
committerChuck <chuck@intelligence.org>2019-10-30 17:32:15 -0700
commit0c999c7521ee52dd00566643f3600627783d2550 (patch)
tree2dd2638860561c34fb2473b79ccb5e6050e2c796 /pkgs/development/tools/misc/itstool
parent6b7f343121b3d77a1c17532c900f8aa40ad8c5e2 (diff)
downloadnixpkgs-0c999c7521ee52dd00566643f3600627783d2550.tar
nixpkgs-0c999c7521ee52dd00566643f3600627783d2550.tar.gz
nixpkgs-0c999c7521ee52dd00566643f3600627783d2550.tar.bz2
nixpkgs-0c999c7521ee52dd00566643f3600627783d2550.tar.lz
nixpkgs-0c999c7521ee52dd00566643f3600627783d2550.tar.xz
nixpkgs-0c999c7521ee52dd00566643f3600627783d2550.tar.zst
nixpkgs-0c999c7521ee52dd00566643f3600627783d2550.zip
itstool: 2.0.2 -> 2.0.6
To get python3 support.  #63174 flipped itstool to python3, but itstool
doesn't support python3 until 2.0.3 (and perhaps does not support it
well until 2.0.5).

Pressing forward instead of rolling back at worldofpeace's suggestion,
who mentions that other distros seem to be able to ship recent versions
of itstool.

Tensions in this space seem two-fold.  One set centers around libxml2
being a low-level C library with sharp edges, manual memory management,
and performance concerns; the python libxml2 wrapper being quite thin
(the most dubious character in this drama); and python's sentiment that
it ought to be quite hard to crash the interpreter casually.  This comes
to a head in https://gitlab.gnome.org/GNOME/libxml2/issues/12 , where a
use-after-free problem in idiomatic-looking python code is declared
working-as-designed.

The other set is around python3 being more UTF-8-aware than libxml2's
python wrapper, such as https://bugzilla.gnome.org/show_bug.cgi?id=789714
and https://src.fedoraproject.org/rpms/libxml2/blob/master/f/libxml2-2.9.8-python3-unicode-errors.patch

itstool is caught in this crossfire merely for being a widely-used
python program that uses XML.
Diffstat (limited to 'pkgs/development/tools/misc/itstool')
-rw-r--r--pkgs/development/tools/misc/itstool/default.nix6
1 files changed, 2 insertions, 4 deletions
diff --git a/pkgs/development/tools/misc/itstool/default.nix b/pkgs/development/tools/misc/itstool/default.nix
index dd536685485..a5c3623b699 100644
--- a/pkgs/development/tools/misc/itstool/default.nix
+++ b/pkgs/development/tools/misc/itstool/default.nix
@@ -1,13 +1,11 @@
 { stdenv, fetchurl, python3 }:
 
 stdenv.mkDerivation rec {
-  # 2.0.3+ breaks the build of gnome3.gnome-desktop
-  # https://github.com/itstool/itstool/issues/17
-  name = "itstool-2.0.2";
+  name = "itstool-2.0.6";
 
   src = fetchurl {
     url = "http://files.itstool.org/itstool/${name}.tar.bz2";
-    sha256 = "bf909fb59b11a646681a8534d5700fec99be83bb2c57badf8c1844512227033a";
+    sha256 = "1acjgf8zlyk7qckdk19iqaca4jcmywd7vxjbcs1mm6kaf8icqcv2";
   };
 
   buildInputs = [ (python3.withPackages(ps: with ps; [ libxml2 ])) ];