diff options
author | Frederik Rietdijk <fridh@fridh.nl> | 2019-07-17 20:36:47 +0200 |
---|---|---|
committer | Frederik Rietdijk <fridh@fridh.nl> | 2019-09-06 15:18:45 +0200 |
commit | f7e28bf5d8181926e600a222cb70180519d09726 (patch) | |
tree | 987b3690f864d0f6cb6736a2f41a26ff458c822f /pkgs/development/python-modules/setuptools/default.nix | |
parent | 7d3b44c9be008a34a3f36a0303fd8d3f20191244 (diff) | |
download | nixpkgs-f7e28bf5d8181926e600a222cb70180519d09726.tar nixpkgs-f7e28bf5d8181926e600a222cb70180519d09726.tar.gz nixpkgs-f7e28bf5d8181926e600a222cb70180519d09726.tar.bz2 nixpkgs-f7e28bf5d8181926e600a222cb70180519d09726.tar.lz nixpkgs-f7e28bf5d8181926e600a222cb70180519d09726.tar.xz nixpkgs-f7e28bf5d8181926e600a222cb70180519d09726.tar.zst nixpkgs-f7e28bf5d8181926e600a222cb70180519d09726.zip |
Split buildPythonPackage into setup hooks
This commit splits the `buildPythonPackage` into multiple setup hooks. Generally, Python packages are built from source to wheels using `setuptools`. The wheels are then installed with `pip`. Tests were often called with `python setup.py test` but this is less common nowadays. Most projects now use a different entry point for running tests, typically `pytest` or `nosetests`. Since the wheel format was introduced more tools were built to generate these, e.g. `flit`. Since PEP 517 is provisionally accepted, defining a build-system independent format (`pyproject.toml`), `pip` can now use that format to execute the correct build-system. In the past I've added support for PEP 517 (`pyproject`) to the Python builder, resulting in a now rather large builder. Furthermore, it was not possible to reuse components elsewhere. Therefore, the builder is now split into multiple setup hooks. The `setuptoolsCheckHook` is included now by default but in time it should be removed from `buildPythonPackage` to make it easier to use another hook (curently one has to pass in `dontUseSetuptoolsCheck`).
Diffstat (limited to 'pkgs/development/python-modules/setuptools/default.nix')
-rw-r--r-- | pkgs/development/python-modules/setuptools/default.nix | 25 |
1 files changed, 14 insertions, 11 deletions
diff --git a/pkgs/development/python-modules/setuptools/default.nix b/pkgs/development/python-modules/setuptools/default.nix index a849dad54aa..8506b0f28d5 100644 --- a/pkgs/development/python-modules/setuptools/default.nix +++ b/pkgs/development/python-modules/setuptools/default.nix @@ -1,15 +1,17 @@ { stdenv +, buildPythonPackage , fetchPypi , python , wrapPython , unzip +, callPackage +, bootstrapped-pip }: -# Should use buildPythonPackage here somehow -stdenv.mkDerivation rec { +buildPythonPackage rec { pname = "setuptools"; version = "41.0.1"; - name = "${python.libPrefix}-${pname}-${version}"; + format = "other"; src = fetchPypi { inherit pname version; @@ -17,8 +19,11 @@ stdenv.mkDerivation rec { sha256 = "a222d126f5471598053c9a77f4b5d4f26eaa1f150ad6e01dcf1a42e185d05613"; }; - nativeBuildInputs = [ unzip wrapPython python.pythonForBuild ]; - doCheck = false; # requires pytest + # There is nothing to build + dontBuild = true; + + nativeBuildInputs = [ bootstrapped-pip ]; + installPhase = '' dst=$out/${python.sitePackages} mkdir -p $dst @@ -27,13 +32,11 @@ stdenv.mkDerivation rec { wrapPythonPrograms ''; - pythonPath = []; - - dontPatchShebangs = true; - - # Python packages built through cross-compilation are always for the host platform. - disallowedReferences = stdenv.lib.optionals (stdenv.hostPlatform != stdenv.buildPlatform) [ python.pythonForBuild ]; + # Adds setuptools to nativeBuildInputs causing infinite recursion. + catchConflicts = false; + # Requires pytest, causing infinite recursion. + doCheck = false; meta = with stdenv.lib; { description = "Utilities to facilitate the installation of Python packages"; |