diff options
author | Robert Scott <code@humanleg.org.uk> | 2021-05-24 23:56:58 +0100 |
---|---|---|
committer | Robert Scott <code@humanleg.org.uk> | 2021-05-24 23:56:58 +0100 |
commit | 1b7c85043775856d6b7ca664c81cee6cc6c04c45 (patch) | |
tree | bf16e052451235da228ec6de8b7b7e40f7027495 /pkgs/development/python-modules/lightgbm | |
parent | b74f11ce9000d17964597a43ef69bf07e76cacec (diff) | |
download | nixpkgs-1b7c85043775856d6b7ca664c81cee6cc6c04c45.tar nixpkgs-1b7c85043775856d6b7ca664c81cee6cc6c04c45.tar.gz nixpkgs-1b7c85043775856d6b7ca664c81cee6cc6c04c45.tar.bz2 nixpkgs-1b7c85043775856d6b7ca664c81cee6cc6c04c45.tar.lz nixpkgs-1b7c85043775856d6b7ca664c81cee6cc6c04c45.tar.xz nixpkgs-1b7c85043775856d6b7ca664c81cee6cc6c04c45.tar.zst nixpkgs-1b7c85043775856d6b7ca664c81cee6cc6c04c45.zip |
python3Packages.lightgbm: fix for darwin
package appears to have its own openmp library detection now and doesn't need the hacks. also add pythonImportsCheck.
Diffstat (limited to 'pkgs/development/python-modules/lightgbm')
-rw-r--r-- | pkgs/development/python-modules/lightgbm/default.nix | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/pkgs/development/python-modules/lightgbm/default.nix b/pkgs/development/python-modules/lightgbm/default.nix index a887c3ec8af..fbe9e04b643 100644 --- a/pkgs/development/python-modules/lightgbm/default.nix +++ b/pkgs/development/python-modules/lightgbm/default.nix @@ -23,19 +23,7 @@ buildPythonPackage rec { dontUseCmakeConfigure = true; - # we never actually explicitly call the install command so this is the only way - # to inject these options to it - however, openmp-library doesn't appear to have - # any effect, so we have to inject it into NIX_LDFLAGS manually below - postPatch = lib.optionalString stdenv.cc.isClang '' - cat >> setup.cfg <<EOF - - [install] - openmp-include-dir=${llvmPackages.openmp}/include - openmp-library=${llvmPackages.openmp}/lib/libomp.dylib - - EOF - ''; - + buildInputs = lib.optional stdenv.cc.isClang [ llvmPackages.openmp ]; propagatedBuildInputs = [ numpy scipy @@ -44,14 +32,13 @@ buildPythonPackage rec { postConfigure = '' export HOME=$(mktemp -d) - '' + lib.optionalString stdenv.cc.isClang '' - export NIX_LDFLAGS="$NIX_LDFLAGS -L${llvmPackages.openmp}/lib -lomp" ''; # The pypi package doesn't distribute the tests from the GitHub # repository. It contains c++ tests which don't seem to wired up to # `make check`. doCheck = false; + pythonImportsCheck = [ "lightgbm" ]; meta = with lib; { description = "A fast, distributed, high performance gradient boosting (GBDT, GBRT, GBM or MART) framework"; |