summary refs log tree commit diff
path: root/pkgs/development/python-modules/Mako
diff options
context:
space:
mode:
authorDrew Risinger <drewrisinger@users.noreply.github.com>2020-09-20 16:27:14 -0400
committerJon <jonringer@users.noreply.github.com>2020-09-22 09:06:39 -0700
commitc24b9331e038e49199abf887e966bd0c6b7b96a0 (patch)
tree2341a55e97c0db61b0090c9b9891eee40dc762ae /pkgs/development/python-modules/Mako
parent7a8fd8de93b10e31f9653e5b6ae247384f161f2e (diff)
downloadnixpkgs-c24b9331e038e49199abf887e966bd0c6b7b96a0.tar
nixpkgs-c24b9331e038e49199abf887e966bd0c6b7b96a0.tar.gz
nixpkgs-c24b9331e038e49199abf887e966bd0c6b7b96a0.tar.bz2
nixpkgs-c24b9331e038e49199abf887e966bd0c6b7b96a0.tar.lz
nixpkgs-c24b9331e038e49199abf887e966bd0c6b7b96a0.tar.xz
nixpkgs-c24b9331e038e49199abf887e966bd0c6b7b96a0.tar.zst
nixpkgs-c24b9331e038e49199abf887e966bd0c6b7b96a0.zip
pythonPackages.Mako: convert to pytestCheckHook
* Expands testing by disabling only known failing tests on pypy.
* Update issue links to GitHub repo.
Diffstat (limited to 'pkgs/development/python-modules/Mako')
-rw-r--r--pkgs/development/python-modules/Mako/default.nix20
1 files changed, 12 insertions, 8 deletions
diff --git a/pkgs/development/python-modules/Mako/default.nix b/pkgs/development/python-modules/Mako/default.nix
index ecf8ae29759..c129e411a47 100644
--- a/pkgs/development/python-modules/Mako/default.nix
+++ b/pkgs/development/python-modules/Mako/default.nix
@@ -1,11 +1,10 @@
 { lib
 , buildPythonPackage
 , fetchPypi
-, python
+, isPyPy
 , markupsafe
-, nose
 , mock
-, isPyPy
+, pytestCheckHook
 }:
 
 buildPythonPackage rec {
@@ -17,13 +16,18 @@ buildPythonPackage rec {
     sha256 = "8195c8c1400ceb53496064314c6736719c6f25e7479cd24c77be3d9361cddc27";
   };
 
-  checkInputs = [ markupsafe nose mock ];
   propagatedBuildInputs = [ markupsafe ];
+  checkInputs = [ pytestCheckHook markupsafe mock ];
 
-  doCheck = !isPyPy;  # https://bitbucket.org/zzzeek/mako/issue/238/2-tests-failed-on-pypy-24-25
-  checkPhase = ''
-    ${python.interpreter} -m unittest discover
-  '';
+  disabledTests = lib.optionals isPyPy [
+    # https://github.com/sqlalchemy/mako/issues/315
+    "test_alternating_file_names"
+    # https://github.com/sqlalchemy/mako/issues/238
+    "test_file_success"
+    "test_stdin_success"
+    # fails on pypy2.7
+    "test_bytestring_passthru"
+  ];
 
   meta = with lib; {
     description = "Super-fast templating language";