summary refs log tree commit diff
path: root/pkgs/development/libraries/v8
diff options
context:
space:
mode:
authorJohannes Bornhold <johannes@bornhold.name>2016-11-02 23:29:31 +0100
committerJohannes Bornhold <johannes@bornhold.name>2016-11-05 22:31:12 +0100
commitb27932a65b4f59fea29375e8a11649700371884e (patch)
tree470d490f02356ffec763e07841023ad1ee864b8c /pkgs/development/libraries/v8
parent3c6e0f1207193c4395183350d0ef878167da89bd (diff)
downloadnixpkgs-b27932a65b4f59fea29375e8a11649700371884e.tar
nixpkgs-b27932a65b4f59fea29375e8a11649700371884e.tar.gz
nixpkgs-b27932a65b4f59fea29375e8a11649700371884e.tar.bz2
nixpkgs-b27932a65b4f59fea29375e8a11649700371884e.tar.lz
nixpkgs-b27932a65b4f59fea29375e8a11649700371884e.tar.xz
nixpkgs-b27932a65b4f59fea29375e8a11649700371884e.tar.zst
nixpkgs-b27932a65b4f59fea29375e8a11649700371884e.zip
v8-3_16_14 tweaks for the build on darwin
The build was originally failing due to a missing libtool. Trying to add
the buildInput "libtool" did not work out, since a few command line
arguments are not supported. I've applied the same workaround as for
"xcodebuild".

The second change is about the install step, where the path of
"libv8.dylib" was just slightly different.
Diffstat (limited to 'pkgs/development/libraries/v8')
-rw-r--r--pkgs/development/libraries/v8/3.16.14.nix5
1 files changed, 3 insertions, 2 deletions
diff --git a/pkgs/development/libraries/v8/3.16.14.nix b/pkgs/development/libraries/v8/3.16.14.nix
index d9addab3030..91a8763d43f 100644
--- a/pkgs/development/libraries/v8/3.16.14.nix
+++ b/pkgs/development/libraries/v8/3.16.14.nix
@@ -25,6 +25,7 @@ stdenv.mkDerivation rec {
 
   configurePhase = stdenv.lib.optionalString stdenv.isDarwin ''
     ln -s /usr/bin/xcodebuild $TMPDIR
+    ln -s /usr/bin/libtool $TMPDIR
     export PATH=$TMPDIR:$PATH
   '' + ''
     PYTHONPATH="tools/generate_shim_headers:$PYTHONPATH" \
@@ -57,8 +58,8 @@ stdenv.mkDerivation rec {
 
   installPhase = ''
     install -vD out/Release/d8 "$out/bin/d8"
-    ${if stdenv.system == "x86_64-darwin" then ''
-    install -vD out/Release/lib.target/libv8.dylib "$out/lib/libv8.dylib"
+    ${if stdenv.isDarwin then ''
+    install -vD out/Release/libv8.dylib "$out/lib/libv8.dylib"
     '' else ''
     install -vD out/Release/lib.target/libv8.so "$out/lib/libv8.so"
     ''}