diff options
author | John Ericson <John.Ericson@Obsidian.Systems> | 2018-03-19 22:41:06 -0400 |
---|---|---|
committer | John Ericson <John.Ericson@Obsidian.Systems> | 2018-04-25 15:28:55 -0400 |
commit | ba52ae50488de85a9cf60a3a04f1c9ca7122ec74 (patch) | |
tree | 48f98024c9244c5d3142ee224d52b267f03853f0 /pkgs/development/interpreters/spidermonkey/1.8.5.nix | |
parent | e40213ed24dea5c816b12f13cbf6606323e31637 (diff) | |
download | nixpkgs-ba52ae50488de85a9cf60a3a04f1c9ca7122ec74.tar nixpkgs-ba52ae50488de85a9cf60a3a04f1c9ca7122ec74.tar.gz nixpkgs-ba52ae50488de85a9cf60a3a04f1c9ca7122ec74.tar.bz2 nixpkgs-ba52ae50488de85a9cf60a3a04f1c9ca7122ec74.tar.lz nixpkgs-ba52ae50488de85a9cf60a3a04f1c9ca7122ec74.tar.xz nixpkgs-ba52ae50488de85a9cf60a3a04f1c9ca7122ec74.tar.zst nixpkgs-ba52ae50488de85a9cf60a3a04f1c9ca7122ec74.zip |
treewide: isArm -> isAarch32
Following legacy packing conventions, `isArm` was defined just for 32-bit ARM instruction set. This is confusing to non packagers though, because Aarch64 is an ARM instruction set. The official ARM overview for ARMv8[1] is surprisingly not confusing, given the overall state of affairs for ARM naming conventions, and offers us a solution. It divides the nomenclature into three levels: ``` ISA: ARMv8 {-A, -R, -M} / \ Mode: Aarch32 Aarch64 | / \ Encoding: A64 A32 T32 ``` At the top is the overall v8 instruction set archicture. Second are the two modes, defined by bitwidth but differing in other semantics too, and buttom are the encodings, (hopefully?) isomorphic if they encode the same mode. The 32 bit encodings are mostly backwards compatible with previous non-Thumb and Thumb encodings, and if so we can pun the mode names to instead mean "sets of compatable or isomorphic encodings", and then voilĂ we have nice names for 32-bit and 64-bit arm instruction sets which do not use the word ARM so as to not confused either laymen or experienced ARM packages. [1]: https://developer.arm.com/products/architecture/a-profile
Diffstat (limited to 'pkgs/development/interpreters/spidermonkey/1.8.5.nix')
-rw-r--r-- | pkgs/development/interpreters/spidermonkey/1.8.5.nix | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/pkgs/development/interpreters/spidermonkey/1.8.5.nix b/pkgs/development/interpreters/spidermonkey/1.8.5.nix index 9a14beb856b..8e51b9b7d58 100644 --- a/pkgs/development/interpreters/spidermonkey/1.8.5.nix +++ b/pkgs/development/interpreters/spidermonkey/1.8.5.nix @@ -11,7 +11,7 @@ stdenv.mkDerivation rec { propagatedBuildInputs = [ nspr ]; - nativeBuildInputs = [ pkgconfig ] ++ lib.optional stdenv.isArm autoconf213; + nativeBuildInputs = [ pkgconfig ] ++ lib.optional stdenv.isAarch32 autoconf213; buildInputs = [ perl python2 zip ]; postUnpack = "sourceRoot=\${sourceRoot}/js/src"; @@ -19,7 +19,7 @@ stdenv.mkDerivation rec { preConfigure = '' export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -I${nspr.dev}/include/nspr" export LIBXUL_DIST=$out - ${lib.optionalString stdenv.isArm "autoreconf --verbose --force"} + ${lib.optionalString stdenv.isAarch32 "autoreconf --verbose --force"} ''; patches = [ @@ -28,7 +28,7 @@ stdenv.mkDerivation rec { url = "https://anonscm.debian.org/cgit/collab-maint/mozjs.git/plain/debian/patches/fix-811665.patch?id=00b15c7841968ab4f7fec409a6b93fa5e1e1d32e"; sha256 = "1q8477xqxiy5d8376k5902l45gd0qkd4nxmhl8vr6rr1pxfcny99"; }) - ] ++ stdenv.lib.optionals stdenv.isArm [ + ] ++ stdenv.lib.optionals stdenv.isAarch32 [ # Explained below in configureFlags for ARM ./1.8.5-findvanilla.patch # Fix for hard float flags. @@ -50,7 +50,7 @@ stdenv.mkDerivation rec { # hack around a make problem, see https://github.com/NixOS/nixpkgs/issues/1279#issuecomment-29547393 preBuild = '' touch -- {.,shell,jsapi-tests}/{-lpthread,-ldl} - ${if stdenv.isArm then "rm -r jit-test/tests/jaeger/bug563000" else ""} + ${if stdenv.isAarch32 then "rm -r jit-test/tests/jaeger/bug563000" else ""} ''; enableParallelBuilding = true; |