gnome3.evince: clean up

There was som cruft, for example, dogtail tests were removed long time ago.

1 files changed, 16 insertions, 27 deletions

diff --git a/pkgs/desktops/gnome-3/core/evince/default.nix b/pkgs/desktops/gnome-3/core/evince/default.nix
index aca10516a38..fab46b35af6 100644
--- a/pkgs/desktops/gnome-3/core/evince/default.nix
+++ b/pkgs/desktops/gnome-3/core/evince/default.nix
@@ -1,47 +1,38 @@
-{ fetchurl, stdenv, pkgconfig, intltool, perl, perlXMLParser, libxml2
+{ fetchurl, stdenv, pkgconfig, intltool, libxml2
 , glib, gtk3, pango, atk, gdk_pixbuf, shared_mime_info, itstool, gnome3
-, poppler, ghostscriptX, djvulibre, libspectre, libsecret , wrapGAppsHook
-, librsvg, gobjectIntrospection
+, poppler, ghostscriptX, djvulibre, libspectre, libsecret, wrapGAppsHook
+, librsvg, gobjectIntrospection, yelp_tools
 , recentListSize ? null # 5 is not enough, allow passing a different number
 , supportXPS ? false    # Open XML Paper Specification via libgxps
-, fetchpatch, autoreconfHook
+, autoreconfHook
 }:
 
 stdenv.mkDerivation rec {
   inherit (import ./src.nix fetchurl) name src;
 
-  # missing help for now; fixing the autogen phase seemed too difficult
-  postPatch = "sed '/@YELP_HELP_RULES@/d' -i help/Makefile.am";
-
-  nativeBuildInputs = [ pkgconfig wrapGAppsHook autoreconfHook/*for patches*/ ];
+  nativeBuildInputs = [
+    pkgconfig gobjectIntrospection intltool itstool wrapGAppsHook yelp_tools autoreconfHook
+  ];
 
   buildInputs = [
-    intltool perl perlXMLParser libxml2
-    glib gtk3 pango atk gdk_pixbuf gobjectIntrospection
-    itstool gnome3.adwaita-icon-theme
+    glib gtk3 pango atk gdk_pixbuf libxml2
     gnome3.libgnome_keyring gnome3.gsettings_desktop_schemas
     poppler ghostscriptX djvulibre libspectre
-    libsecret librsvg gnome3.adwaita-icon-theme gnome3.dconf
+    libsecret librsvg gnome3.adwaita-icon-theme
   ] ++ stdenv.lib.optional supportXPS gnome3.libgxps;
 
   configureFlags = [
-    "--disable-nautilus" # Do not use nautilus
+    "--disable-nautilus" # Do not build nautilus plugin
     "--enable-introspection"
     (if supportXPS then "--enable-xps" else "--disable-xps")
   ];
 
   NIX_CFLAGS_COMPILE = "-I${gnome3.glib.dev}/include/gio-unix-2.0";
 
-  preConfigure = with stdenv.lib;
-    optionalString doCheck ''
-      for file in test/*.py; do
-        echo "patching $file"
-        sed '1s,/usr,${python},' -i "$file"
-      done
-    '' + optionalString (recentListSize != null) ''
-      sed -i 's/\(gtk_recent_chooser_set_limit .*\)5)/\1${builtins.toString recentListSize})/' shell/ev-open-recent-action.c
-      sed -i 's/\(if (++n_items == \)5\(.*\)/\1${builtins.toString recentListSize}\2/' shell/ev-window.c
-    '';
+  preConfigure = stdenv.lib.optionalString (recentListSize != null) ''
+    sed -i 's/\(gtk_recent_chooser_set_limit .*\)5)/\1${builtins.toString recentListSize})/' shell/ev-open-recent-action.c
+    sed -i 's/\(if (++n_items == \)5\(.*\)/\1${builtins.toString recentListSize}\2/' shell/ev-window.c
+  '';
 
   preFixup = ''
     gappsWrapperArgs+=(--prefix XDG_DATA_DIRS : "${shared_mime_info}/share")
@@ -49,10 +40,8 @@ stdenv.mkDerivation rec {
 
   enableParallelBuilding = true;
 
-  doCheck = false; # would need pythonPackages.dogTail, which is missing
-
   meta = with stdenv.lib; {
-    homepage = https://www.gnome.org/projects/evince/;
+    homepage = https://wiki.gnome.org/Apps/Evince;
     description = "GNOME's document viewer";
 
     longDescription = ''
@@ -64,6 +53,6 @@ stdenv.mkDerivation rec {
 
     license = stdenv.lib.licenses.gpl2Plus;
     platforms = platforms.linux;
-    maintainers = [ maintainers.vcunat ];
+    maintainers = gnome3.maintainers ++ [ maintainers.vcunat ];
   };
 }