summary refs log tree commit diff
path: root/pkgs/build-support/libredirect
diff options
context:
space:
mode:
authorAlyssa Ross <hi@alyssa.is>2023-01-23 15:34:53 +0000
committerAlyssa Ross <hi@alyssa.is>2023-01-23 15:34:53 +0000
commit12d2821bf56be27d33b90f109220a342a11828ca (patch)
treea7899a309b261e217e6ef4be8585e5f7dd29d806 /pkgs/build-support/libredirect
parentc5c7778f0987596bfeddf1b0d15b897761b3e516 (diff)
downloadnixpkgs-12d2821bf56be27d33b90f109220a342a11828ca.tar
nixpkgs-12d2821bf56be27d33b90f109220a342a11828ca.tar.gz
nixpkgs-12d2821bf56be27d33b90f109220a342a11828ca.tar.bz2
nixpkgs-12d2821bf56be27d33b90f109220a342a11828ca.tar.lz
nixpkgs-12d2821bf56be27d33b90f109220a342a11828ca.tar.xz
nixpkgs-12d2821bf56be27d33b90f109220a342a11828ca.tar.zst
nixpkgs-12d2821bf56be27d33b90f109220a342a11828ca.zip
treewide: remove -ldl linker flags
With all libcs I'm aware of, libdl is now either empty (Glibc, musl,
uclibc, illumos), a symlink to libc or equivalent (Apple), or does not
exist (FreeBSD, NetBSD).  So explicitly linking libdl now does nothing
for the former platforms, and breaks the build for the latter
platforms.

With this patch I've removed -ldl from all overridden linker flags for
all free packages in Nixpkgs.  Everything still seems to build.
Diffstat (limited to 'pkgs/build-support/libredirect')
-rw-r--r--pkgs/build-support/libredirect/default.nix6
1 files changed, 3 insertions, 3 deletions
diff --git a/pkgs/build-support/libredirect/default.nix b/pkgs/build-support/libredirect/default.nix
index b5eb21e5ba4..6e2de7fa11b 100644
--- a/pkgs/build-support/libredirect/default.nix
+++ b/pkgs/build-support/libredirect/default.nix
@@ -46,14 +46,14 @@ else stdenv.mkDerivation rec {
       -L${llvmPackages_13.clang.libc}/lib \
       -Wl,-install_name,$libName \
       -Wall -std=c99 -O3 -fPIC libredirect.c \
-      -ldl -shared -o "$libName"
+      -shared -o "$libName"
     '' else if stdenv.isDarwin then ''
     $CC -Wall -std=c99 -O3 -fPIC libredirect.c \
       -Wl,-install_name,$out/lib/$libName \
-      -ldl -shared -o "$libName"
+      -shared -o "$libName"
     '' else ''
     $CC -Wall -std=c99 -O3 -fPIC libredirect.c \
-      -ldl -shared -o "$libName"
+      -shared -o "$libName"
     ''}
 
     if [ -n "$doInstallCheck" ]; then