summary refs log tree commit diff
path: root/pkgs/build-support/fetchurl
diff options
context:
space:
mode:
authorGraham Christensen <graham@grahamc.com>2019-04-24 12:09:35 -0400
committerGitHub <noreply@github.com>2019-04-24 12:09:35 -0400
commitb26153450c744bf901fd2fe2e07ac24e5aff0ef4 (patch)
treec813fc128aa43aac1a08d0f95fad5a214ae7a5a9 /pkgs/build-support/fetchurl
parent6a5f81e138175c73f7e24bb55bd3b07e1f026215 (diff)
parent6fad2ae94bfb9beb2cb9a9f6e32b895de341285e (diff)
downloadnixpkgs-b26153450c744bf901fd2fe2e07ac24e5aff0ef4.tar
nixpkgs-b26153450c744bf901fd2fe2e07ac24e5aff0ef4.tar.gz
nixpkgs-b26153450c744bf901fd2fe2e07ac24e5aff0ef4.tar.bz2
nixpkgs-b26153450c744bf901fd2fe2e07ac24e5aff0ef4.tar.lz
nixpkgs-b26153450c744bf901fd2fe2e07ac24e5aff0ef4.tar.xz
nixpkgs-b26153450c744bf901fd2fe2e07ac24e5aff0ef4.tar.zst
nixpkgs-b26153450c744bf901fd2fe2e07ac24e5aff0ef4.zip
Merge pull request #48325 from transumption/201810/warn-on-fetchurl-rev-archives
fetchurl: warn on rev archives, resolves #32999
Diffstat (limited to 'pkgs/build-support/fetchurl')
-rw-r--r--pkgs/build-support/fetchurl/builder.sh11
1 files changed, 10 insertions, 1 deletions
diff --git a/pkgs/build-support/fetchurl/builder.sh b/pkgs/build-support/fetchurl/builder.sh
index f9bc8b602f4..74fdc320835 100644
--- a/pkgs/build-support/fetchurl/builder.sh
+++ b/pkgs/build-support/fetchurl/builder.sh
@@ -118,7 +118,6 @@ if test -n "$showURLs"; then
     exit 0
 fi
 
-
 if test -n "$preferHashedMirrors"; then
     tryHashedMirrors
 fi
@@ -128,6 +127,16 @@ set -o noglob
 
 success=
 for url in $urls; do
+    if [ -z "$postFetch" ]; then
+       case "$url" in
+           https://github.com/*/archive/*)
+               echo "warning: archives from GitHub revisions should use fetchFromGitHub"
+               ;;
+           https://gitlab.com/*/-/archive/*)
+               echo "warning: archives from GitLab revisions should use fetchFromGitLab"
+               ;;
+       esac
+    fi
     tryDownload "$url"
     if test -n "$success"; then finish; fi
 done