summary refs log tree commit diff
path: root/pkgs/applications/networking/browsers/chromium/source
diff options
context:
space:
mode:
authoraszlig <aszlig@redmoonstudios.org>2015-07-02 10:41:51 +0200
committeraszlig <aszlig@redmoonstudios.org>2015-07-04 02:31:45 +0200
commit7e6d6e034db419c0da2743f1aca90e1d50f97135 (patch)
tree5e3201f60102297a1d25746605b8df7d8ad2eb4b /pkgs/applications/networking/browsers/chromium/source
parenta80437e2360197aaf89a54a97f5aa2ee1c89eb44 (diff)
downloadnixpkgs-7e6d6e034db419c0da2743f1aca90e1d50f97135.tar
nixpkgs-7e6d6e034db419c0da2743f1aca90e1d50f97135.tar.gz
nixpkgs-7e6d6e034db419c0da2743f1aca90e1d50f97135.tar.bz2
nixpkgs-7e6d6e034db419c0da2743f1aca90e1d50f97135.tar.lz
nixpkgs-7e6d6e034db419c0da2743f1aca90e1d50f97135.tar.xz
nixpkgs-7e6d6e034db419c0da2743f1aca90e1d50f97135.tar.zst
nixpkgs-7e6d6e034db419c0da2743f1aca90e1d50f97135.zip
chromium: Disable setuid sandbox without errors.
Just silencing the error will not prevent Chromium from trying to start
up the SUID sandbox anyway, thus flooding stderr with:

LaunchProcess: failed to execvp:

After digging a bit in the source code I found out that the SUID sandbox
binary is indeed used, but only for setting oom_score_adj within the
user namespace (as "root"). So let's build the sandbox binary and of
course don't set setuid bit.

These annoying error messages were originally introduced by 0aad4b7 and
I'm deeply sorry for annoying you guys out there with them.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Diffstat (limited to 'pkgs/applications/networking/browsers/chromium/source')
-rw-r--r--pkgs/applications/networking/browsers/chromium/source/default.nix2
1 files changed, 0 insertions, 2 deletions
diff --git a/pkgs/applications/networking/browsers/chromium/source/default.nix b/pkgs/applications/networking/browsers/chromium/source/default.nix
index 68573d0c6af..bb68e4a0ca8 100644
--- a/pkgs/applications/networking/browsers/chromium/source/default.nix
+++ b/pkgs/applications/networking/browsers/chromium/source/default.nix
@@ -101,8 +101,6 @@ in stdenv.mkDerivation {
       -e 's|/bin/echo|echo|' \
       -e "/python_arch/s/: *'[^']*'/: '""'/" \
       "$out/build/common.gypi" "$main/chrome/chrome_tests.gypi"
-    sed -i -e '/LOG.*no_suid_error/d' \
-      "$main/content/browser/browser_main_loop.cc"
   '' + optionalString useOpenSSL ''
     cat $opensslPatches | patch -p1 -d "$bundled/openssl/openssl"
   '';