summary refs log tree commit diff
path: root/nixos
diff options
context:
space:
mode:
authorSamuel Dionne-Riel <samuel@dionne-riel.com>2018-11-28 19:14:54 -0500
committerSamuel Dionne-Riel <samuel@dionne-riel.com>2018-11-28 19:14:54 -0500
commit38644380493cb87c209115c54dc908a89f43e91b (patch)
treeb50dad73818c8e977fdd8da9fe703af4698380b0 /nixos
parent0a367c41ea2b956b7952e1e81da6d51e95a310cd (diff)
downloadnixpkgs-38644380493cb87c209115c54dc908a89f43e91b.tar
nixpkgs-38644380493cb87c209115c54dc908a89f43e91b.tar.gz
nixpkgs-38644380493cb87c209115c54dc908a89f43e91b.tar.bz2
nixpkgs-38644380493cb87c209115c54dc908a89f43e91b.tar.lz
nixpkgs-38644380493cb87c209115c54dc908a89f43e91b.tar.xz
nixpkgs-38644380493cb87c209115c54dc908a89f43e91b.tar.zst
nixpkgs-38644380493cb87c209115c54dc908a89f43e91b.zip
iso-image: Do not use batch operations for `mcopy`.
```
       b      Batch mode. Optimized for huge recursive copies, but less secure if a crash happens during the copy.
```

It seems the "less secure if a crash happens" does not need a crash to
happen.

With batch mode:

```
/[...]/.
  Start (0) does not point to parent (___)
```

For pretty much everything copied in.

Without batch mode, everything passes `fsck`.

See #51150
Diffstat (limited to 'nixos')
-rw-r--r--nixos/modules/installer/cd-dvd/iso-image.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/nixos/modules/installer/cd-dvd/iso-image.nix b/nixos/modules/installer/cd-dvd/iso-image.nix
index dbf7643c336..aa8003fef2c 100644
--- a/nixos/modules/installer/cd-dvd/iso-image.nix
+++ b/nixos/modules/installer/cd-dvd/iso-image.nix
@@ -339,7 +339,7 @@ let
       echo "Image size: $image_size"
       truncate --size=$image_size "$out"
       ${pkgs.libfaketime}/bin/faketime "2000-01-01 00:00:00" ${pkgs.dosfstools}/sbin/mkfs.vfat -i 12345678 -n EFIBOOT "$out"
-      mcopy -bpsvm -i "$out" ./* ::
+      mcopy -psvm -i "$out" ./* ::
       # Verify the FAT partition.
       ${pkgs.dosfstools}/sbin/fsck.vfat -vn "$out"
     ''; # */