summary refs log tree commit diff
path: root/nixos
diff options
context:
space:
mode:
authorNiklas Hambüchen <mail@nh2.me>2020-10-11 03:15:19 +0200
committerNiklas Hambüchen <mail@nh2.me>2020-11-08 01:15:33 +0100
commit169ab0b89f124694e81639ff52c8bafc695d961d (patch)
tree98fe90ad695960c29fb360363a0258bb6db27edd /nixos
parentc0f4be6652415416316fc7220b7c7ed16ee59c90 (diff)
downloadnixpkgs-169ab0b89f124694e81639ff52c8bafc695d961d.tar
nixpkgs-169ab0b89f124694e81639ff52c8bafc695d961d.tar.gz
nixpkgs-169ab0b89f124694e81639ff52c8bafc695d961d.tar.bz2
nixpkgs-169ab0b89f124694e81639ff52c8bafc695d961d.tar.lz
nixpkgs-169ab0b89f124694e81639ff52c8bafc695d961d.tar.xz
nixpkgs-169ab0b89f124694e81639ff52c8bafc695d961d.tar.zst
nixpkgs-169ab0b89f124694e81639ff52c8bafc695d961d.zip
redis service: Listen on localhost by default. Fixes #100192.
All other database servers in NixOS also use this safe-by-default setting.
Diffstat (limited to 'nixos')
-rw-r--r--nixos/doc/manual/release-notes/rl-2103.xml5
-rw-r--r--nixos/modules/services/databases/redis.nix9
2 files changed, 11 insertions, 3 deletions
diff --git a/nixos/doc/manual/release-notes/rl-2103.xml b/nixos/doc/manual/release-notes/rl-2103.xml
index 7fd7ff5c2a9..dc61f095a5c 100644
--- a/nixos/doc/manual/release-notes/rl-2103.xml
+++ b/nixos/doc/manual/release-notes/rl-2103.xml
@@ -161,6 +161,11 @@
    </listitem>
    <listitem>
     <para>
+     The setting <xref linkend="opt-services.redis.bind" /> defaults to <literal>127.0.0.1</literal> now, making Redis listen on the loopback interface only, and not all public network interfaces.
+    </para>
+   </listitem>
+   <listitem>
+    <para>
      NixOS now emits a deprecation warning if systemd's <literal>StartLimitInterval</literal> setting is used in a <literal>serviceConfig</literal> section instead of in a <literal>unitConfig</literal>; that setting is deprecated and now undocumented for the service section by systemd upstream, but still effective and somewhat buggy there, which can be confusing. See <link xlink:href="https://github.com/NixOS/nixpkgs/issues/45785">#45785</link> for details.
     </para>
     <para>
diff --git a/nixos/modules/services/databases/redis.nix b/nixos/modules/services/databases/redis.nix
index f1777854e14..6b8853ae390 100644
--- a/nixos/modules/services/databases/redis.nix
+++ b/nixos/modules/services/databases/redis.nix
@@ -87,9 +87,12 @@ in
 
       bind = mkOption {
         type = with types; nullOr str;
-        default = null; # All interfaces
-        description = "The IP interface to bind to.";
-        example = "127.0.0.1";
+        default = "127.0.0.1";
+        description = ''
+          The IP interface to bind to.
+          <literal>null</literal> means "all interfaces".
+        '';
+        example = "192.0.2.1";
       };
 
       unixSocket = mkOption {