diff options
| author | Silvan Mosberger <contact@infinisil.com> | 2022-03-25 17:41:57 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-25 17:41:57 +0100 |
| commit | 99d9d45630cc82449d8ac29048117f3a7203ac96 (patch) | |
| tree | 725fbb08c4aaffc2c391dceab0595ed7f445564b /doc | |
| parent | de23459252f7708643c62fd2822157f28898c2a5 (diff) | |
| parent | 7b32b8b66f80c10e7d509d62051dfd64470b3ebb (diff) | |
| download | nixpkgs-99d9d45630cc82449d8ac29048117f3a7203ac96.tar nixpkgs-99d9d45630cc82449d8ac29048117f3a7203ac96.tar.gz nixpkgs-99d9d45630cc82449d8ac29048117f3a7203ac96.tar.bz2 nixpkgs-99d9d45630cc82449d8ac29048117f3a7203ac96.tar.lz nixpkgs-99d9d45630cc82449d8ac29048117f3a7203ac96.tar.xz nixpkgs-99d9d45630cc82449d8ac29048117f3a7203ac96.tar.zst nixpkgs-99d9d45630cc82449d8ac29048117f3a7203ac96.zip | |
Merge pull request #164651 from Infinisil/remove-optionSet
lib/modules: Finally remove deprecated types.optionSet
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/contributing/reviewing-contributions.chapter.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index 7a13a3f3b40..3417854730e 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -122,7 +122,7 @@ Reviewing process: - [CODEOWNERS](https://help.github.com/articles/about-codeowners/) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers. - Ensure that the module tests, if any, are succeeding. - Ensure that the introduced options are correct. - - Type should be appropriate (string related types differs in their merging capabilities, `optionSet` and `string` types are deprecated). + - Type should be appropriate (string related types differs in their merging capabilities, `loaOf` and `string` types are deprecated). - Description, default and example should be provided. - Ensure that option changes are backward compatible. - `mkRenamedOptionModuleWith` provides a way to make option changes backward compatible. @@ -157,7 +157,7 @@ Reviewing process: - Ensure that the module tests, if any, are succeeding. - Ensure that the introduced options are correct. - - Type should be appropriate (string related types differs in their merging capabilities, `optionSet` and `string` types are deprecated). + - Type should be appropriate (string related types differs in their merging capabilities, `loaOf` and `string` types are deprecated). - Description, default and example should be provided. - Ensure that module `meta` field is present - Maintainers should be declared in `meta.maintainers`. |