diff options
| author | Silvan Mosberger <contact@infinisil.com> | 2022-03-18 00:32:53 +0100 |
|---|---|---|
| committer | Silvan Mosberger <contact@infinisil.com> | 2022-03-18 04:51:27 +0100 |
| commit | 96698efe0cd9e0ffe38d95e043acafa926fa5e0d (patch) | |
| tree | 1e2280053c7ae3eaa24b5d87265a941fc8765425 /doc | |
| parent | 6cc306ec23b7b63835be7277647554d14a869f28 (diff) | |
| download | nixpkgs-96698efe0cd9e0ffe38d95e043acafa926fa5e0d.tar nixpkgs-96698efe0cd9e0ffe38d95e043acafa926fa5e0d.tar.gz nixpkgs-96698efe0cd9e0ffe38d95e043acafa926fa5e0d.tar.bz2 nixpkgs-96698efe0cd9e0ffe38d95e043acafa926fa5e0d.tar.lz nixpkgs-96698efe0cd9e0ffe38d95e043acafa926fa5e0d.tar.xz nixpkgs-96698efe0cd9e0ffe38d95e043acafa926fa5e0d.tar.zst nixpkgs-96698efe0cd9e0ffe38d95e043acafa926fa5e0d.zip | |
lib/modules: Finally remove deprecated types.optionSet
types.optionSet has been deprecated for almost 10 years now (0e333688cea468a28516bf6935648c03ed62a7bb)! A removal was already attempted in 2019 (27982b408e465554b8831f492362bc87ed0ec02a), but it was promptly reinstantiated since some third-party uses were discovered (f531ce75e4178c6867cc1d0f7fec96b2d5c3f1cb). It's finally time to remove it for good :)
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/contributing/reviewing-contributions.chapter.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index 0a90781d0c5..b78fda6c288 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -122,7 +122,7 @@ Reviewing process: - [CODEOWNERS](https://help.github.com/articles/about-codeowners/) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers. - Ensure that the module tests, if any, are succeeding. - Ensure that the introduced options are correct. - - Type should be appropriate (string related types differs in their merging capabilities, `optionSet` and `string` types are deprecated). + - Type should be appropriate (string related types differs in their merging capabilities, `loaOf` and `string` types are deprecated). - Description, default and example should be provided. - Ensure that option changes are backward compatible. - `mkRenamedOptionModule` and `mkAliasOptionModule` functions provide way to make option changes backward compatible. @@ -157,7 +157,7 @@ Reviewing process: - Ensure that the module tests, if any, are succeeding. - Ensure that the introduced options are correct. - - Type should be appropriate (string related types differs in their merging capabilities, `optionSet` and `string` types are deprecated). + - Type should be appropriate (string related types differs in their merging capabilities, `loaOf` and `string` types are deprecated). - Description, default and example should be provided. - Ensure that module `meta` field is present - Maintainers should be declared in `meta.maintainers`. |