diff options
| author | Robert Hensing <roberth@users.noreply.github.com> | 2023-07-16 14:21:17 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-16 14:21:17 +0200 |
| commit | 12d2f0da28a47f907825939630b4a0e8122fabe3 (patch) | |
| tree | 95e74dce61858639315df6aab0c3de88343a938e /doc/contributing | |
| parent | 83f78d066a1c6c55aff592fcbebb5d5e00572895 (diff) | |
| parent | a0a4354a13f7c25bad03173ffa528d220dec5a63 (diff) | |
| download | nixpkgs-12d2f0da28a47f907825939630b4a0e8122fabe3.tar nixpkgs-12d2f0da28a47f907825939630b4a0e8122fabe3.tar.gz nixpkgs-12d2f0da28a47f907825939630b4a0e8122fabe3.tar.bz2 nixpkgs-12d2f0da28a47f907825939630b4a0e8122fabe3.tar.lz nixpkgs-12d2f0da28a47f907825939630b4a0e8122fabe3.tar.xz nixpkgs-12d2f0da28a47f907825939630b4a0e8122fabe3.tar.zst nixpkgs-12d2f0da28a47f907825939630b4a0e8122fabe3.zip | |
Merge pull request #240136 from NixOS/doc-review-patches
doc/reviewing-contributions: Add points about patches
Diffstat (limited to 'doc/contributing')
| -rw-r--r-- | doc/contributing/reviewing-contributions.chapter.md | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index b4caf11f6d4..10c72fe3d13 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -62,6 +62,8 @@ Sample template for a package update review is provided below. - [ ] package build on ARCHITECTURE - [ ] executables tested on ARCHITECTURE - [ ] all depending packages build +- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed +- [ ] patches that are remotely available are fetched rather than vendored ##### Possible improvements @@ -105,7 +107,8 @@ Sample template for a new package review is provided below. - [ ] source is fetched using the appropriate function - [ ] the list of `phases` is not overridden - [ ] when a phase (like `installPhase`) is overridden it starts with `runHook preInstall` and ends with `runHook postInstall`. -- [ ] patches that are remotely available are fetched with `fetchpatch` +- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed +- [ ] patches that are remotely available are fetched rather than vendored ##### Possible improvements |