summary refs log tree commit diff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorLuca Bruno <lethalman88@gmail.com>2015-07-10 11:56:04 +0200
committerLuca Bruno <lethalman88@gmail.com>2015-07-10 11:56:04 +0200
commitb4e5181dde01c6938825484f210120b54f1a7d2a (patch)
tree203f6d52663d8167a6bff48b86051685e72fb32a /CONTRIBUTING.md
parent48f44bfa697151f1d7efe5f3c19073917dd40c24 (diff)
downloadnixpkgs-b4e5181dde01c6938825484f210120b54f1a7d2a.tar
nixpkgs-b4e5181dde01c6938825484f210120b54f1a7d2a.tar.gz
nixpkgs-b4e5181dde01c6938825484f210120b54f1a7d2a.tar.bz2
nixpkgs-b4e5181dde01c6938825484f210120b54f1a7d2a.tar.lz
nixpkgs-b4e5181dde01c6938825484f210120b54f1a7d2a.tar.xz
nixpkgs-b4e5181dde01c6938825484f210120b54f1a7d2a.tar.zst
nixpkgs-b4e5181dde01c6938825484f210120b54f1a7d2a.zip
CONTRIBUTING: add some notes about commit policy
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md10
1 files changed, 10 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 764508ca25f..9938604eef5 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -67,3 +67,13 @@
 * Don't create additional commits, do
   * `git rebase -i`
   * `git push --force` to your branch.
+
+## Commit policy
+
+* Commits must be sufficiently tested before being merged, both the master and staging branches.
+* Hydra builds for master and stagingshould not be used as testing platform, it's a build farm for changes that have been already tested.
+* Master should only see non-breaking commits that do not cause mass rebuilds.
+* Staging should only see non-breaking mass-rebuild commits. That means it's not to be used for testing, changes must have been well tested already. [Read policy here](http://comments.gmane.org/gmane.linux.distributions.nixos/13447).
+* If staging is already in a broken state, please refrain from adding extra new breakages. Stabilize it for a few days, merge into master, then resume development on staging. [Keep an eye on the staging evaluations here](http://hydra.nixos.org/jobset/nixpkgs/staging#tabs-evaluations).
+* When changing the bootloader installation process, extra care must be taken. Grub installations cannot be rolled back, hence changes may break people installation forever. For any non-trivial change to the bootloader please file a PR asking for review, especially from @edolstra.
+