summary refs log tree commit diff
diff options
context:
space:
mode:
authorJohn Ericson <John.Ericson@Obsidian.Systems>2021-04-23 21:47:28 +0000
committerJohn Ericson <John.Ericson@Obsidian.Systems>2021-04-23 21:54:42 +0000
commitf684c917a6c3919e8dff6b79f317da8ad148e44b (patch)
treee4915a5ed6564c5f1a98659274d459fb9853402a
parent068a59a3943a6a4395db20c874902df4b83c0369 (diff)
downloadnixpkgs-f684c917a6c3919e8dff6b79f317da8ad148e44b.tar
nixpkgs-f684c917a6c3919e8dff6b79f317da8ad148e44b.tar.gz
nixpkgs-f684c917a6c3919e8dff6b79f317da8ad148e44b.tar.bz2
nixpkgs-f684c917a6c3919e8dff6b79f317da8ad148e44b.tar.lz
nixpkgs-f684c917a6c3919e8dff6b79f317da8ad148e44b.tar.xz
nixpkgs-f684c917a6c3919e8dff6b79f317da8ad148e44b.tar.zst
nixpkgs-f684c917a6c3919e8dff6b79f317da8ad148e44b.zip
stdenvNoCC: Fix `hasCC` attr during cross, remove `noCC`
`hasCC` was getting overridden in the cross bootstrapping (for GHCJS),
which preventing the default logic from re-triggering for `stdenvNoCC`.

Also remove `stdenv.noCC` which is obseleted by `stdenv.hasCC`.
-rw-r--r--pkgs/stdenv/generic/make-derivation.nix2
-rw-r--r--pkgs/top-level/all-packages.nix2
2 files changed, 2 insertions, 2 deletions
diff --git a/pkgs/stdenv/generic/make-derivation.nix b/pkgs/stdenv/generic/make-derivation.nix
index 74609412782..4fc58238e5e 100644
--- a/pkgs/stdenv/generic/make-derivation.nix
+++ b/pkgs/stdenv/generic/make-derivation.nix
@@ -104,7 +104,7 @@ in rec {
                                       ++ depsHostHost ++ depsHostHostPropagated
                                       ++ buildInputs ++ propagatedBuildInputs
                                       ++ depsTargetTarget ++ depsTargetTargetPropagated) == 0;
-      dontAddHostSuffix = attrs ? outputHash && !noNonNativeDeps || (stdenv.noCC or false);
+      dontAddHostSuffix = attrs ? outputHash && !noNonNativeDeps || !stdenv.hasCC;
       supportedHardeningFlags = [ "fortify" "stackprotector" "pie" "pic" "strictoverflow" "format" "relro" "bindnow" ];
                               # Musl-based platforms will keep "pie", other platforms will not.
       defaultHardeningFlags = if stdenv.hostPlatform.isMusl &&
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 7ef9f066a99..5740ce52095 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -30,7 +30,7 @@ in
   # just the plain stdenv.
   stdenv_32bit = lowPrio (if stdenv.hostPlatform.is32bit then stdenv else multiStdenv);
 
-  stdenvNoCC = stdenv.override { cc = null; extraAttrs.noCC = true; };
+  stdenvNoCC = stdenv.override { cc = null; hasCC = false; };
 
   mkStdenvNoLibs = stdenv: let
     bintools = stdenv.cc.bintools.override {