summary refs log tree commit diff
diff options
context:
space:
mode:
authorRobert Scott <github@humanleg.org.uk>2022-08-08 00:50:48 +0100
committerWinter <winter@winter.cafe>2022-08-08 11:16:19 -0400
commitd5aaf15094e607fa87d04486d41db4e771c200fb (patch)
treea575cf39ca4523d621600173cfd5d97178d120e0
parent4bc913e2dc8d850aae3e4a85b677526c84fd5370 (diff)
downloadnixpkgs-d5aaf15094e607fa87d04486d41db4e771c200fb.tar
nixpkgs-d5aaf15094e607fa87d04486d41db4e771c200fb.tar.gz
nixpkgs-d5aaf15094e607fa87d04486d41db4e771c200fb.tar.bz2
nixpkgs-d5aaf15094e607fa87d04486d41db4e771c200fb.tar.lz
nixpkgs-d5aaf15094e607fa87d04486d41db4e771c200fb.tar.xz
nixpkgs-d5aaf15094e607fa87d04486d41db4e771c200fb.tar.zst
nixpkgs-d5aaf15094e607fa87d04486d41db4e771c200fb.zip
Revert "zlib: add patch for CVE-2022-37434"
-rw-r--r--pkgs/development/libraries/zlib/CVE-2022-37434.patch32
-rw-r--r--pkgs/development/libraries/zlib/default.nix1
2 files changed, 0 insertions, 33 deletions
diff --git a/pkgs/development/libraries/zlib/CVE-2022-37434.patch b/pkgs/development/libraries/zlib/CVE-2022-37434.patch
deleted file mode 100644
index dc84d3a1d38..00000000000
--- a/pkgs/development/libraries/zlib/CVE-2022-37434.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From eff308af425b67093bab25f80f1ae950166bece1 Mon Sep 17 00:00:00 2001
-From: Mark Adler <fork@madler.net>
-Date: Sat, 30 Jul 2022 15:51:11 -0700
-Subject: [PATCH] Fix a bug when getting a gzip header extra field with
- inflate().
-
-If the extra field was larger than the space the user provided with
-inflateGetHeader(), and if multiple calls of inflate() delivered
-the extra header data, then there could be a buffer overflow of the
-provided space. This commit assures that provided space is not
-exceeded.
----
- inflate.c | 5 +++--
- 1 file changed, 3 insertions(+), 2 deletions(-)
-
-diff --git a/inflate.c b/inflate.c
-index 7be8c6366..7a7289749 100644
---- a/inflate.c
-+++ b/inflate.c
-@@ -763,9 +763,10 @@ int flush;
-                 copy = state->length;
-                 if (copy > have) copy = have;
-                 if (copy) {
-+                    len = state->head->extra_len - state->length;
-                     if (state->head != Z_NULL &&
--                        state->head->extra != Z_NULL) {
--                        len = state->head->extra_len - state->length;
-+                        state->head->extra != Z_NULL &&
-+                        len < state->head->extra_max) {
-                         zmemcpy(state->head->extra + len, next,
-                                 len + copy > state->head->extra_max ?
-                                 state->head->extra_max - len : copy);
diff --git a/pkgs/development/libraries/zlib/default.nix b/pkgs/development/libraries/zlib/default.nix
index a51fec31c14..1527be44f7a 100644
--- a/pkgs/development/libraries/zlib/default.nix
+++ b/pkgs/development/libraries/zlib/default.nix
@@ -48,7 +48,6 @@ stdenv.mkDerivation (rec {
     # TODO: remove the patch if upstream releases https://github.com/madler/zlib/commit/ec3df00224d4b396e2ac6586ab5d25f673caa4c2
     # see https://github.com/NixOS/nixpkgs/issues/170539 for history.
     ./comprehensive-crc-validation-for-wrong-implementations.patch
-    ./CVE-2022-37434.patch
   ];
 
   strictDeps = true;