summary refs log tree commit diff
diff options
context:
space:
mode:
authorEric Seidel <gridaphobe@gmail.com>2015-02-17 20:10:26 -0800
committerEric Seidel <gridaphobe@gmail.com>2015-02-17 20:10:26 -0800
commitd2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1 (patch)
tree6dec2c26ea744dd300afe897ebe7052236d2e91c
parenta78d164b1e6c10f39c87b8907685a711a6de338c (diff)
downloadnixpkgs-d2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1.tar
nixpkgs-d2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1.tar.gz
nixpkgs-d2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1.tar.bz2
nixpkgs-d2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1.tar.lz
nixpkgs-d2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1.tar.xz
nixpkgs-d2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1.tar.zst
nixpkgs-d2a987d6e36c7bca253bf08dfe22f2beaa3b2ee1.zip
fix travis evaluation by providing explicit libiconv for the rare cases
that need it, like uclibc
-rw-r--r--pkgs/os-specific/linux/uclibc/default.nix4
-rw-r--r--pkgs/top-level/all-packages.nix7
2 files changed, 8 insertions, 3 deletions
diff --git a/pkgs/os-specific/linux/uclibc/default.nix b/pkgs/os-specific/linux/uclibc/default.nix
index b856a788348..88cf59cf8b7 100644
--- a/pkgs/os-specific/linux/uclibc/default.nix
+++ b/pkgs/os-specific/linux/uclibc/default.nix
@@ -1,4 +1,4 @@
-{stdenv, fetchurl, linuxHeaders, libiconv, cross ? null, gccCross ? null,
+{stdenv, fetchurl, linuxHeaders, libiconvReal, cross ? null, gccCross ? null,
 extraConfig ? ""}:
 
 assert stdenv.isLinux;
@@ -95,7 +95,7 @@ stdenv.mkDerivation {
 
   passthru = {
     # Derivations may check for the existance of this attribute, to know what to link to.
-    inherit libiconv;
+    libiconv = libiconvReal;
   };
 
   meta = {
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index f0c98ce6c2f..c7997f1d263 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -6285,11 +6285,16 @@ let
 
   libgsf = callPackage ../development/libraries/libgsf { };
 
+  # glibc provides libiconv so systems with glibc don't need to build libiconv
+  # separately, but we also provide libiconvReal, which will always be a
+  # standalone libiconv, just in case you want it
   libiconv =
     if stdenv.isGlibc
     then stdenv.cc.libc
     else callPackage ../development/libraries/libiconv { };
 
+  libiconvReal = callPackage ../development/libraries/libiconv { };
+
   # On non-GNU systems we need GNU Gettext for libintl.
   libintlOrEmpty = stdenv.lib.optional (!stdenv.isLinux) gettext;
 
@@ -9163,7 +9168,7 @@ let
   uclibc = callPackage ../os-specific/linux/uclibc { };
 
   uclibcCross = lowPrio (callPackage ../os-specific/linux/uclibc {
-    inherit fetchurl stdenv libiconv;
+    inherit fetchurl stdenv libiconvReal;
     linuxHeaders = linuxHeadersCross;
     gccCross = gccCrossStageStatic;
     cross = assert crossSystem != null; crossSystem;