summary refs log tree commit diff
diff options
context:
space:
mode:
authorzowoq <59103226+zowoq@users.noreply.github.com>2020-08-04 10:35:19 +1000
committerzowoq <59103226+zowoq@users.noreply.github.com>2020-08-10 16:01:03 +1000
commitcc06d7a26f247df071c551a980147baff8a75ff7 (patch)
tree3575d69a26b8c7328c6a7e34e7593b6644ed690c
parent0a53fcc79d9cbefb26c69e2059e884a85327ad96 (diff)
downloadnixpkgs-cc06d7a26f247df071c551a980147baff8a75ff7.tar
nixpkgs-cc06d7a26f247df071c551a980147baff8a75ff7.tar.gz
nixpkgs-cc06d7a26f247df071c551a980147baff8a75ff7.tar.bz2
nixpkgs-cc06d7a26f247df071c551a980147baff8a75ff7.tar.lz
nixpkgs-cc06d7a26f247df071c551a980147baff8a75ff7.tar.xz
nixpkgs-cc06d7a26f247df071c551a980147baff8a75ff7.tar.zst
nixpkgs-cc06d7a26f247df071c551a980147baff8a75ff7.zip
buildGoModule: change doCheck default to true
-rw-r--r--nixos/doc/manual/release-notes/rl-2009.xml5
-rw-r--r--pkgs/development/go-modules/generic/default.nix2
2 files changed, 6 insertions, 1 deletions
diff --git a/nixos/doc/manual/release-notes/rl-2009.xml b/nixos/doc/manual/release-notes/rl-2009.xml
index d97e810b94c..5009ef4d873 100644
--- a/nixos/doc/manual/release-notes/rl-2009.xml
+++ b/nixos/doc/manual/release-notes/rl-2009.xml
@@ -666,6 +666,11 @@ services.postgresql.dataDir = "/var/db/postgresql";
    </listitem>
    <listitem>
     <para>
+     <literal>buildGoModule</literal> <literal>doCheck</literal> now defaults to <literal>true</literal>.
+    </para>
+   </listitem>
+   <listitem>
+    <para>
      Packages built using <literal>buildRustPackage</literal> now use <literal>release</literal>
      mode for the <literal>checkPhase</literal> by default.
     </para>
diff --git a/pkgs/development/go-modules/generic/default.nix b/pkgs/development/go-modules/generic/default.nix
index 68a4fe8dd6a..25b031a8229 100644
--- a/pkgs/development/go-modules/generic/default.nix
+++ b/pkgs/development/go-modules/generic/default.nix
@@ -210,7 +210,7 @@ let
       runHook postBuild
     '';
 
-    doCheck = args.doCheck or false;
+    doCheck = args.doCheck or true;
     checkPhase = args.checkPhase or ''
       runHook preCheck