summary refs log tree commit diff
diff options
context:
space:
mode:
authorRick van Schijndel <rol3517@gmail.com>2021-05-02 22:04:10 +0200
committertomberek <tomberek@users.noreply.github.com>2021-05-12 19:23:00 -0400
commitbf434ca1a1601ac790c5bde57a7d3af5ebd48d2a (patch)
tree5ec1096b0bbe6cd7d4e26f651bc7703659106050
parentb6475a8f907053a9e742fab46d34c123876d18fd (diff)
downloadnixpkgs-bf434ca1a1601ac790c5bde57a7d3af5ebd48d2a.tar
nixpkgs-bf434ca1a1601ac790c5bde57a7d3af5ebd48d2a.tar.gz
nixpkgs-bf434ca1a1601ac790c5bde57a7d3af5ebd48d2a.tar.bz2
nixpkgs-bf434ca1a1601ac790c5bde57a7d3af5ebd48d2a.tar.lz
nixpkgs-bf434ca1a1601ac790c5bde57a7d3af5ebd48d2a.tar.xz
nixpkgs-bf434ca1a1601ac790c5bde57a7d3af5ebd48d2a.tar.zst
nixpkgs-bf434ca1a1601ac790c5bde57a7d3af5ebd48d2a.zip
libnixxml: fix build + support cross + enable tests
Run the symlinking of the ./bootstrap script in the preAutoreconf hook.

Remove the tests that are broken and enable testing again.

Put correct dependencies in nativeBuildInputs vs buildInputs vs
checkInputs to support cross-compilation.
-rw-r--r--pkgs/development/libraries/libnixxml/default.nix33
1 files changed, 28 insertions, 5 deletions
diff --git a/pkgs/development/libraries/libnixxml/default.nix b/pkgs/development/libraries/libnixxml/default.nix
index 40459dbca22..62440487e0f 100644
--- a/pkgs/development/libraries/libnixxml/default.nix
+++ b/pkgs/development/libraries/libnixxml/default.nix
@@ -11,17 +11,40 @@ stdenv.mkDerivation {
     sha256 = "sha256-HKQnCkO1TDs1e0MDil0Roq4YRembqRHQvb7lK3GAftQ=";
   };
 
-  preConfigure = ''
-    ./bootstrap
+  postPatch = ''
+    # Remove broken test
+    substituteInPlace tests/draw/Makefile.am \
+      --replace "draw-wrong.sh" ""
+    rm tests/draw/draw-wrong.sh
+  '';
+
+  preAutoreconf = ''
+    # Copied from bootstrap script
+    ln -s README.md README
+    mkdir -p config
   '';
 
   configureFlags = [ "--with-gd" "--with-glib" ];
   CFLAGS = "-Wall";
 
-  nativeBuildInputs = [ autoreconfHook pkg-config ];
-  buildInputs = [ libxml2 gd.dev glib getopt libxslt nix ];
+  strictDeps = true;
+  nativeBuildInputs = [
+    autoreconfHook
+    pkg-config
+    getopt
+    libxslt
+  ];
+  buildInputs = [
+    libxml2
+    gd.dev
+    glib
+    nix
+  ];
+  checkInputs = [
+    nix
+  ];
 
-  doCheck = false;
+  doCheck = true;
 
   meta = with lib; {
     description = "XML-based Nix-friendly data integration library";