summary refs log tree commit diff
diff options
context:
space:
mode:
authorSergei Trofimovich <slyich@gmail.com>2021-11-28 16:04:23 +0000
committerSergei Trofimovich <slyich@gmail.com>2021-11-28 16:06:12 +0000
commita94a2370bb1831dc212e8567bd3e273fd0b5be7f (patch)
tree11a0df6ab34c9fcd348dfada8232f065134c8273
parent78cb77b29d37a9663e05b61abb4fa09465da4b70 (diff)
downloadnixpkgs-a94a2370bb1831dc212e8567bd3e273fd0b5be7f.tar
nixpkgs-a94a2370bb1831dc212e8567bd3e273fd0b5be7f.tar.gz
nixpkgs-a94a2370bb1831dc212e8567bd3e273fd0b5be7f.tar.bz2
nixpkgs-a94a2370bb1831dc212e8567bd3e273fd0b5be7f.tar.lz
nixpkgs-a94a2370bb1831dc212e8567bd3e273fd0b5be7f.tar.xz
nixpkgs-a94a2370bb1831dc212e8567bd3e273fd0b5be7f.tar.zst
nixpkgs-a94a2370bb1831dc212e8567bd3e273fd0b5be7f.zip
noice: fix build against ncurses-6.3
Without the change the build on upcoming `ncurses-6.3` fails as:

    noice.c:377:9: error: format not a string literal and no format arguments [-Werror=format-security]
      377 |         printw(str);
          |         ^~~~~~
-rw-r--r--pkgs/applications/misc/noice/default.nix6
1 files changed, 6 insertions, 0 deletions
diff --git a/pkgs/applications/misc/noice/default.nix b/pkgs/applications/misc/noice/default.nix
index 73648d896d0..e67346c5171 100644
--- a/pkgs/applications/misc/noice/default.nix
+++ b/pkgs/applications/misc/noice/default.nix
@@ -12,6 +12,12 @@ stdenv.mkDerivation rec {
     sha256 = "0975j4m93s9a21pazwdzn4gqhkngwq7q6ghp0q8a75r6c4fb7aar";
   };
 
+  postPatch = ''
+    # Add support for ncurses-6.3. Can be dropped with 0.9 release.
+    # Fixed upstream at: https://git.2f30.org/noice/commit/53c35e6b340b7c135038e00057a198f03cb7d7cf.html
+    substituteInPlace noice.c --replace 'printw(str);' 'printw("%s", str);'
+  '';
+
   configFile = optionalString (conf!=null) (builtins.toFile "config.def.h" conf);
   preBuild = optionalString (conf!=null) "cp ${configFile} config.def.h";