summary refs log tree commit diff
diff options
context:
space:
mode:
authorTravis A. Everett <travis.a.everett@gmail.com>2021-12-05 21:44:55 -0600
committerzowoq <59103226+zowoq@users.noreply.github.com>2021-12-10 00:51:14 +1000
commit61727e0e57e73113aca16981ea00275b299fbf94 (patch)
treef86e944806d2f1bfd5f0fc5f7822ed1ac197b1a3
parentd1a6f9d04a4528c77ad244b381d0678f026ff40e (diff)
downloadnixpkgs-61727e0e57e73113aca16981ea00275b299fbf94.tar
nixpkgs-61727e0e57e73113aca16981ea00275b299fbf94.tar.gz
nixpkgs-61727e0e57e73113aca16981ea00275b299fbf94.tar.bz2
nixpkgs-61727e0e57e73113aca16981ea00275b299fbf94.tar.lz
nixpkgs-61727e0e57e73113aca16981ea00275b299fbf94.tar.xz
nixpkgs-61727e0e57e73113aca16981ea00275b299fbf94.tar.zst
nixpkgs-61727e0e57e73113aca16981ea00275b299fbf94.zip
bashup-events: rm shellcheck from checkPhase
An advance in shellcheck started causing new failures here, which
inspired me to think a little more lucidly and realize it's a bad
idea to shellcheck something that isn't maintainer-developed. The
outcomes are all annoying timewasters. :[
-rw-r--r--pkgs/development/libraries/bashup-events/generic.nix5
1 files changed, 1 insertions, 4 deletions
diff --git a/pkgs/development/libraries/bashup-events/generic.nix b/pkgs/development/libraries/bashup-events/generic.nix
index fd4e2cfe9f5..2f99a261681 100644
--- a/pkgs/development/libraries/bashup-events/generic.nix
+++ b/pkgs/development/libraries/bashup-events/generic.nix
@@ -3,7 +3,6 @@
   lib
 , resholvePackage
 , bash
-, shellcheck
 , doCheck ? true
 , doInstallCheck ? true
   # variant-specific
@@ -50,12 +49,10 @@ resholvePackage rec {
   '';
 
   inherit doCheck;
-  checkInputs = [ shellcheck bash ];
+  checkInputs = [ bash ];
 
-  # check based on https://github.com/bashup/events/blob/master/.dkrc
   checkPhase = ''
     runHook preCheck
-    SHELLCHECK_OPTS='-e SC2016,SC2145' ${shellcheck}/bin/shellcheck ./bashup.events
     ${bash}/bin/bash -n ./bashup.events
     ${bash}/bin/bash ./bashup.events
     runHook postCheck