diff options
| author | Matthew Bauer <mjbauer95@gmail.com> | 2019-01-26 21:09:37 -0500 |
|---|---|---|
| committer | Matthew Bauer <mjbauer95@gmail.com> | 2019-01-26 21:14:36 -0500 |
| commit | 329913f7339df9657c2c728c1c0a3009f860d9f5 (patch) | |
| tree | 001472efb71f74cdcb944e588c2d3ee17ee525cb | |
| parent | cc74c0399ecee6291b25084c17a5e355671263d9 (diff) | |
| download | nixpkgs-329913f7339df9657c2c728c1c0a3009f860d9f5.tar nixpkgs-329913f7339df9657c2c728c1c0a3009f860d9f5.tar.gz nixpkgs-329913f7339df9657c2c728c1c0a3009f860d9f5.tar.bz2 nixpkgs-329913f7339df9657c2c728c1c0a3009f860d9f5.tar.lz nixpkgs-329913f7339df9657c2c728c1c0a3009f860d9f5.tar.xz nixpkgs-329913f7339df9657c2c728c1c0a3009f860d9f5.tar.zst nixpkgs-329913f7339df9657c2c728c1c0a3009f860d9f5.zip | |
setup.sh: put SHELL in flagsArray
We don’t want to modify makeFlags, that is given to us by our environment. Adding to it could lead to duplicates after repeated use. Fixes #27533
| -rw-r--r-- | pkgs/stdenv/generic/setup.sh | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/pkgs/stdenv/generic/setup.sh b/pkgs/stdenv/generic/setup.sh index 03fa589138d..0f63693e09e 100644 --- a/pkgs/stdenv/generic/setup.sh +++ b/pkgs/stdenv/generic/setup.sh @@ -1012,13 +1012,11 @@ buildPhase() { else foundMakefile=1 - # See https://github.com/NixOS/nixpkgs/pull/1354#issuecomment-31260409 - makeFlags="SHELL=$SHELL $makeFlags" - # Old bash empty array hack # shellcheck disable=SC2086 local flagsArray=( ${enableParallelBuilding:+-j${NIX_BUILD_CORES} -l${NIX_BUILD_CORES}} + SHELL=$SHELL $makeFlags ${makeFlagsArray+"${makeFlagsArray[@]}"} $buildFlags ${buildFlagsArray+"${buildFlagsArray[@]}"} ) @@ -1057,6 +1055,7 @@ checkPhase() { # shellcheck disable=SC2086 local flagsArray=( ${enableParallelChecking:+-j${NIX_BUILD_CORES} -l${NIX_BUILD_CORES}} + SHELL=$SHELL $makeFlags ${makeFlagsArray+"${makeFlagsArray[@]}"} ${checkFlags:-VERBOSE=y} ${checkFlagsArray+"${checkFlagsArray[@]}"} ${checkTarget} @@ -1082,6 +1081,7 @@ installPhase() { # Old bash empty array hack # shellcheck disable=SC2086 local flagsArray=( + SHELL=$SHELL $makeFlags ${makeFlagsArray+"${makeFlagsArray[@]}"} $installFlags ${installFlagsArray+"${installFlagsArray[@]}"} ${installTargets:-install} @@ -1189,6 +1189,7 @@ installCheckPhase() { # shellcheck disable=SC2086 local flagsArray=( ${enableParallelChecking:+-j${NIX_BUILD_CORES} -l${NIX_BUILD_CORES}} + SHELL=$SHELL $makeFlags ${makeFlagsArray+"${makeFlagsArray[@]}"} $installCheckFlags ${installCheckFlagsArray+"${installCheckFlagsArray[@]}"} ${installCheckTarget:-installcheck} |