diff options
author | Anderson Torres <torres.anderson.85@protonmail.com> | 2023-10-03 00:06:05 -0300 |
---|---|---|
committer | Anderson Torres <torres.anderson.85@protonmail.com> | 2023-10-09 17:49:02 -0300 |
commit | 0de25e25b06591af5bb2362256d4cecbe29eb556 (patch) | |
tree | e4c5ea6db568cbb94e3aa5ae74d047c35244b363 | |
parent | cbd816146dd34796dcda643f4539fb5c9c5613f1 (diff) | |
download | nixpkgs-0de25e25b06591af5bb2362256d4cecbe29eb556.tar nixpkgs-0de25e25b06591af5bb2362256d4cecbe29eb556.tar.gz nixpkgs-0de25e25b06591af5bb2362256d4cecbe29eb556.tar.bz2 nixpkgs-0de25e25b06591af5bb2362256d4cecbe29eb556.tar.lz nixpkgs-0de25e25b06591af5bb2362256d4cecbe29eb556.tar.xz nixpkgs-0de25e25b06591af5bb2362256d4cecbe29eb556.tar.zst nixpkgs-0de25e25b06591af5bb2362256d4cecbe29eb556.zip |
lib: refactor
- rename `(enable|with)Feature(As|)` inputs to more descriptive names
-rw-r--r-- | lib/strings.nix | 27 |
1 files changed, 15 insertions, 12 deletions
diff --git a/lib/strings.nix b/lib/strings.nix index d7642ce10fa..628669d86bb 100644 --- a/lib/strings.nix +++ b/lib/strings.nix @@ -854,7 +854,7 @@ rec { assert (lib.isBool flag); mesonOption feature (if flag then "enabled" else "disabled"); - /* Create an --{enable,disable}-<feat> string that can be passed to + /* Create an --{enable,disable}-<feature> string that can be passed to standard GNU Autoconf scripts. Example: @@ -863,11 +863,12 @@ rec { enableFeature false "shared" => "--disable-shared" */ - enableFeature = enable: feat: - assert isString feat; # e.g. passing openssl instead of "openssl" - "--${if enable then "enable" else "disable"}-${feat}"; + enableFeature = flag: feature: + assert lib.isBool flag; + assert lib.isString feature; # e.g. passing openssl instead of "openssl" + "--${if flag then "enable" else "disable"}-${feature}"; - /* Create an --{enable-<feat>=<value>,disable-<feat>} string that can be passed to + /* Create an --{enable-<feature>=<value>,disable-<feature>} string that can be passed to standard GNU Autoconf scripts. Example: @@ -876,9 +877,10 @@ rec { enableFeatureAs false "shared" (throw "ignored") => "--disable-shared" */ - enableFeatureAs = enable: feat: value: enableFeature enable feat + optionalString enable "=${value}"; + enableFeatureAs = flag: feature: value: + enableFeature flag feature + optionalString flag "=${value}"; - /* Create an --{with,without}-<feat> string that can be passed to + /* Create an --{with,without}-<feature> string that can be passed to standard GNU Autoconf scripts. Example: @@ -887,11 +889,11 @@ rec { withFeature false "shared" => "--without-shared" */ - withFeature = with_: feat: - assert isString feat; # e.g. passing openssl instead of "openssl" - "--${if with_ then "with" else "without"}-${feat}"; + withFeature = flag: feature: + assert isString feature; # e.g. passing openssl instead of "openssl" + "--${if flag then "with" else "without"}-${feature}"; - /* Create an --{with-<feat>=<value>,without-<feat>} string that can be passed to + /* Create an --{with-<feature>=<value>,without-<feature>} string that can be passed to standard GNU Autoconf scripts. Example: @@ -900,7 +902,8 @@ rec { withFeatureAs false "shared" (throw "ignored") => "--without-shared" */ - withFeatureAs = with_: feat: value: withFeature with_ feat + optionalString with_ "=${value}"; + withFeatureAs = flag: feature: value: + withFeature flag feature + optionalString flag "=${value}"; /* Create a fixed width string with additional prefix to match required width. |