diff options
| author | Artturi <Artturin@artturin.com> | 2021-11-14 04:06:07 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-11-14 04:06:07 +0200 |
| commit | cbb28ac95f5f0ccd4c49c623961cecc5da64341f (patch) | |
| tree | fba963adadda221db96c18e9ec38b8f55beb92f4 /.github | |
| parent | ba9578bed0d58ce64e62dfbc310904f321bda66c (diff) | |
| parent | a60634790aec785fe0e33e15e95a7f344ff4d45d (diff) | |
| download | nixpkgs-cbb28ac95f5f0ccd4c49c623961cecc5da64341f.tar nixpkgs-cbb28ac95f5f0ccd4c49c623961cecc5da64341f.tar.gz nixpkgs-cbb28ac95f5f0ccd4c49c623961cecc5da64341f.tar.bz2 nixpkgs-cbb28ac95f5f0ccd4c49c623961cecc5da64341f.tar.lz nixpkgs-cbb28ac95f5f0ccd4c49c623961cecc5da64341f.tar.xz nixpkgs-cbb28ac95f5f0ccd4c49c623961cecc5da64341f.tar.zst nixpkgs-cbb28ac95f5f0ccd4c49c623961cecc5da64341f.zip | |
Merge pull request #145387 from Artturin/updaterequesttemplate
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 168d40f16a9..f7d16df8724 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -26,7 +26,7 @@ Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing- - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages -- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` +- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking |