diff options
author | Zach Reizner <zachr@google.com> | 2017-06-23 20:19:05 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2017-06-27 10:55:46 -0700 |
commit | b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6 (patch) | |
tree | 5ca61d7071d53f5661b78cc799702c9e65d74490 /sys_util/src/guest_memory.rs | |
parent | 34959d42c145cf5bb00bb429fee698df3c06a401 (diff) | |
download | crosvm-b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6.tar crosvm-b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6.tar.gz crosvm-b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6.tar.bz2 crosvm-b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6.tar.lz crosvm-b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6.tar.xz crosvm-b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6.tar.zst crosvm-b3fba4535c322ebbd4f53c69ec9b7153f9bb04d6.zip |
sys_util: implement VolatileMemory for Mmap and GuestMemory
Mmap and GuestMemory are the intended targets for the VolatileMemory trait. TEST=cargo test BUG=None Change-Id: Ie228b5daef691a6dcb80841be1c3dddb4b19ffc4 Reviewed-on: https://chromium-review.googlesource.com/547335 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>
Diffstat (limited to 'sys_util/src/guest_memory.rs')
-rw-r--r-- | sys_util/src/guest_memory.rs | 50 |
1 files changed, 49 insertions, 1 deletions
diff --git a/sys_util/src/guest_memory.rs b/sys_util/src/guest_memory.rs index f7ad298..ae96ead 100644 --- a/sys_util/src/guest_memory.rs +++ b/sys_util/src/guest_memory.rs @@ -9,6 +9,7 @@ use std::result; use std::sync::Arc; use data_model::DataInit; +use data_model::volatile_memory::*; use guest_address::GuestAddress; use mmap::MemoryMapping; @@ -56,7 +57,8 @@ impl GuestMemory { } } - let mapping = MemoryMapping::new(range.1).map_err(|_| Error::MemoryMappingFailed)?; + let mapping = MemoryMapping::new(range.1) + .map_err(|_| Error::MemoryMappingFailed)?; regions.push(MemoryRegion { mapping: mapping, guest_base: range.0, @@ -282,6 +284,19 @@ impl GuestMemory { } } +impl VolatileMemory for GuestMemory { + fn get_slice(&self, offset: usize, count: usize) -> VolatileMemoryResult<VolatileSlice> { + for region in self.regions.iter() { + if offset >= region.guest_base.0 && offset < region_end(region).0 { + return region + .mapping + .get_slice(offset - region.guest_base.0, count); + } + } + Err(VolatileMemoryError::OutOfBounds { addr: offset }) + } +} + #[cfg(test)] mod tests { use super::*; @@ -316,4 +331,37 @@ mod tests { assert_eq!(val1, num1); assert_eq!(val2, num2); } + + #[test] + fn test_ref_load_u64() { + let start_addr1 = GuestAddress(0x0); + let start_addr2 = GuestAddress(0x1000); + let gm = GuestMemory::new(&vec![(start_addr1, 0x1000), (start_addr2, 0x1000)]).unwrap(); + + let val1: u64 = 0xaa55aa55aa55aa55; + let val2: u64 = 0x55aa55aa55aa55aa; + gm.write_obj_at_addr(val1, GuestAddress(0x500)).unwrap(); + gm.write_obj_at_addr(val2, GuestAddress(0x1000 + 32)) + .unwrap(); + let num1: u64 = gm.get_ref(0x500).unwrap().load(); + let num2: u64 = gm.get_ref(0x1000 + 32).unwrap().load(); + assert_eq!(val1, num1); + assert_eq!(val2, num2); + } + + #[test] + fn test_ref_store_u64() { + let start_addr1 = GuestAddress(0x0); + let start_addr2 = GuestAddress(0x1000); + let gm = GuestMemory::new(&vec![(start_addr1, 0x1000), (start_addr2, 0x1000)]).unwrap(); + + let val1: u64 = 0xaa55aa55aa55aa55; + let val2: u64 = 0x55aa55aa55aa55aa; + gm.get_ref(0x500).unwrap().store(val1); + gm.get_ref(0x1000 + 32).unwrap().store(val2); + let num1: u64 = gm.read_obj_from_addr(GuestAddress(0x500)).unwrap(); + let num2: u64 = gm.read_obj_from_addr(GuestAddress(0x1000 + 32)).unwrap(); + assert_eq!(val1, num1); + assert_eq!(val2, num2); + } } |