diff options
author | David Tolnay <dtolnay@chromium.org> | 2019-03-08 16:56:14 -0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-08 02:51:37 -0700 |
commit | fdac5ede468e0fddfe527d6108430ee932b02fc3 (patch) | |
tree | 398c2ace79eea2babb4439810c43b793068fd8cc /resources | |
parent | 98895ac05d42ed346a161035134600b0d0e0bb87 (diff) | |
download | crosvm-fdac5ede468e0fddfe527d6108430ee932b02fc3.tar crosvm-fdac5ede468e0fddfe527d6108430ee932b02fc3.tar.gz crosvm-fdac5ede468e0fddfe527d6108430ee932b02fc3.tar.bz2 crosvm-fdac5ede468e0fddfe527d6108430ee932b02fc3.tar.lz crosvm-fdac5ede468e0fddfe527d6108430ee932b02fc3.tar.xz crosvm-fdac5ede468e0fddfe527d6108430ee932b02fc3.tar.zst crosvm-fdac5ede468e0fddfe527d6108430ee932b02fc3.zip |
edition: Use dyn syntax for trait objects
Found by running: `cargo rustc -- -D bare_trait_objects` Bare trait objects like `&Trait` and `Box<Trait>` are soft-deprecated in 2018 edition and will start warning at some point. As part of this, I replaced `Box<Trait + 'static>` with `Box<dyn Trait>` because the 'static bound is implied for boxed trait objects. TEST=cargo check --all-features TEST=cargo check --target aarch64-unknown-linux-gnu TEST=local kokoro Change-Id: I41c4f13530bece8a34a8ed1c1afd7035b8f86f19 Reviewed-on: https://chromium-review.googlesource.com/1513059 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: David Tolnay <dtolnay@chromium.org>
Diffstat (limited to 'resources')
-rw-r--r-- | resources/src/gpu_allocator.rs | 3 | ||||
-rw-r--r-- | resources/src/system_allocator.rs | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/resources/src/gpu_allocator.rs b/resources/src/gpu_allocator.rs index c2f1c20..7b40a22 100644 --- a/resources/src/gpu_allocator.rs +++ b/resources/src/gpu_allocator.rs @@ -113,6 +113,7 @@ pub fn create_gpu_memory_allocator() -> Result<Option<Box<GpuMemoryAllocator>>, } #[cfg(not(feature = "wl-dmabuf"))] -pub fn create_gpu_memory_allocator() -> Result<Option<Box<GpuMemoryAllocator>>, GpuAllocatorError> { +pub fn create_gpu_memory_allocator( +) -> Result<Option<Box<dyn GpuMemoryAllocator>>, GpuAllocatorError> { Ok(None) } diff --git a/resources/src/system_allocator.rs b/resources/src/system_allocator.rs index 0810889..8cde454 100644 --- a/resources/src/system_allocator.rs +++ b/resources/src/system_allocator.rs @@ -27,7 +27,7 @@ pub struct SystemAllocator { io_address_space: Option<AddressAllocator>, device_address_space: AddressAllocator, mmio_address_space: AddressAllocator, - gpu_allocator: Option<Box<GpuMemoryAllocator>>, + gpu_allocator: Option<Box<dyn GpuMemoryAllocator>>, next_irq: u32, } @@ -98,7 +98,7 @@ impl SystemAllocator { } /// Gets an allocator to be used for GPU memory. - pub fn gpu_memory_allocator(&self) -> Option<&GpuMemoryAllocator> { + pub fn gpu_memory_allocator(&self) -> Option<&dyn GpuMemoryAllocator> { self.gpu_allocator.as_ref().map(|v| v.as_ref()) } } |