summary refs log tree commit diff
path: root/kvm
diff options
context:
space:
mode:
authorZach Reizner <zachr@google.com>2019-09-10 16:11:18 -0700
committerCommit Bot <commit-bot@chromium.org>2019-09-11 09:34:12 +0000
commit506105dc0dcfbbdec907f672e8d782b2f8604447 (patch)
treede31f815541f9195f537bc8142832b68f766762c /kvm
parent532533dd3994ef2047dea770e799831b4c38418e (diff)
downloadcrosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar
crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.gz
crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.bz2
crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.lz
crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.xz
crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.tar.zst
crosvm-506105dc0dcfbbdec907f672e8d782b2f8604447.zip
use `SharedMemory::{named, anon}` to replace `::new`
The new constructors are shorter and omit the bare `None` in the `anon`
call sites which gave no clues to the reader what the effect of that
`None` was. This should improve readability.

TEST=./build_test
BUG=None

Change-Id: I2e34e7df9a4ccc5da50edf4e963a6a42e3d84b22
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1797188
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Commit-Queue: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Diffstat (limited to 'kvm')
-rw-r--r--kvm/tests/dirty_log.rs2
-rw-r--r--kvm/tests/read_only_memory.rs4
2 files changed, 3 insertions, 3 deletions
diff --git a/kvm/tests/dirty_log.rs b/kvm/tests/dirty_log.rs
index 4efb208..8d8e56d 100644
--- a/kvm/tests/dirty_log.rs
+++ b/kvm/tests/dirty_log.rs
@@ -18,7 +18,7 @@ fn test_run() {
     let mem_size = 0x10000;
     let load_addr = GuestAddress(0x1000);
     let guest_mem = GuestMemory::new(&[]).unwrap();
-    let mut mem = SharedMemory::new(None).expect("failed to create shared memory");
+    let mut mem = SharedMemory::anon().expect("failed to create shared memory");
     mem.set_size(mem_size)
         .expect("failed to set shared memory size");
     let mmap =
diff --git a/kvm/tests/read_only_memory.rs b/kvm/tests/read_only_memory.rs
index c1dd854..54f0acd 100644
--- a/kvm/tests/read_only_memory.rs
+++ b/kvm/tests/read_only_memory.rs
@@ -20,7 +20,7 @@ fn test_run() {
     let mem_size = 0x2000;
     let load_addr = GuestAddress(0x1000);
     let guest_mem = GuestMemory::new(&[]).unwrap();
-    let mut mem = SharedMemory::new(None).expect("failed to create shared memory");
+    let mut mem = SharedMemory::anon().expect("failed to create shared memory");
     mem.set_size(mem_size)
         .expect("failed to set shared memory size");
     let mmap =
@@ -55,7 +55,7 @@ fn test_run() {
 
     // Give some read only memory for the test code to read from and force a vcpu exit when it reads
     // from it.
-    let mut mem_ro = SharedMemory::new(None).expect("failed to create shared memory");
+    let mut mem_ro = SharedMemory::anon().expect("failed to create shared memory");
     mem_ro
         .set_size(0x1000)
         .expect("failed to set shared memory size");