summary refs log tree commit diff
path: root/kokoro
diff options
context:
space:
mode:
authorDavid Tolnay <dtolnay@chromium.org>2019-01-23 12:31:05 -0800
committerchrome-bot <chrome-bot@chromium.org>2019-01-24 00:51:51 -0800
commit5c8dae6ad7829b2db5317e0431d0ab2de5a9d725 (patch)
tree2dbf697d75d981c1664273a957355acaf078bffa /kokoro
parentd3144f7a52608d5295dd5bf8edc4f3d76ae4ad82 (diff)
downloadcrosvm-5c8dae6ad7829b2db5317e0431d0ab2de5a9d725.tar
crosvm-5c8dae6ad7829b2db5317e0431d0ab2de5a9d725.tar.gz
crosvm-5c8dae6ad7829b2db5317e0431d0ab2de5a9d725.tar.bz2
crosvm-5c8dae6ad7829b2db5317e0431d0ab2de5a9d725.tar.lz
crosvm-5c8dae6ad7829b2db5317e0431d0ab2de5a9d725.tar.xz
crosvm-5c8dae6ad7829b2db5317e0431d0ab2de5a9d725.tar.zst
crosvm-5c8dae6ad7829b2db5317e0431d0ab2de5a9d725.zip
kokoro: Avoid docker build from stdin to support COPY
Under the old command, the build would fail with:

    Step 15/25 : COPY pkgconfig/* /usr/lib/pkgconfig
    COPY failed: no source files were specified

The Docker documentation at
https://docs.docker.com/v18.03/engine/reference/builder/
explains:

    Note: If you build using STDIN (docker build - < somefile), there is
    no build context, so COPY cant be used.

TEST=it built successfully

Change-Id: I4d9fcb085009f4a47d7caecabf6eb711f5cab6b7
Reviewed-on: https://chromium-review.googlesource.com/1431356
Commit-Ready: David Tolnay <dtolnay@chromium.org>
Tested-by: David Tolnay <dtolnay@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Diffstat (limited to 'kokoro')
-rw-r--r--kokoro/README.md6
1 files changed, 2 insertions, 4 deletions
diff --git a/kokoro/README.md b/kokoro/README.md
index 48a23a2..201ab54 100644
--- a/kokoro/README.md
+++ b/kokoro/README.md
@@ -12,8 +12,7 @@ is built with a [`Dockerfile`](Dockerfile).
 Assuming a Docker daemon is already running, build the `crosvm-base` image:
 
 ```shell
-cd crosvm/kokoro
-docker build -t crosvm-base - < Dockerfile
+docker build -t crosvm-base path/to/crosvm/kokoro
 ```
 
 Here is how to use the image to test a crosvm repository located at `$CROSVM_SRC`:
@@ -33,8 +32,7 @@ If an update or new library is needed or any other adjustment is required, a new
 generated as follows:
 
 ```shell
-cd crosvm/kokoro
-docker build -t crosvm-base - < Dockerfile
+docker build -t crosvm-base path/to/crosvm/kokoro
 docker save crosvm-base | xz -T 0 -z >crosvm-base.tar.xz
 ```