diff options
author | David Tolnay <dtolnay@chromium.org> | 2019-03-01 18:07:56 -0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-02 17:41:31 -0800 |
commit | c69f97542a6071f78d48a743ee94119a93bc9471 (patch) | |
tree | 69ee27de806bf460c108219d9d2c64bd633cf35d /devices/src/proxy.rs | |
parent | 5e1b46cbd8cb031a12c0fb20e94670f1007fd789 (diff) | |
download | crosvm-c69f97542a6071f78d48a743ee94119a93bc9471.tar crosvm-c69f97542a6071f78d48a743ee94119a93bc9471.tar.gz crosvm-c69f97542a6071f78d48a743ee94119a93bc9471.tar.bz2 crosvm-c69f97542a6071f78d48a743ee94119a93bc9471.tar.lz crosvm-c69f97542a6071f78d48a743ee94119a93bc9471.tar.xz crosvm-c69f97542a6071f78d48a743ee94119a93bc9471.tar.zst crosvm-c69f97542a6071f78d48a743ee94119a93bc9471.zip |
error: Consistently use Display instead of error description()
The description method is deprecated and its signature forces less helpful error messages than what Display can provide. BUG=none TEST=cargo check --all-features TEST=cargo check --target aarch64-unknown-linux-gnu Change-Id: I27fc99d59d0ef457c5273dc53e4c563ef439c2c0 Reviewed-on: https://chromium-review.googlesource.com/1497735 Commit-Ready: David Tolnay <dtolnay@chromium.org> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Dylan Reid <dgreid@chromium.org>
Diffstat (limited to 'devices/src/proxy.rs')
-rw-r--r-- | devices/src/proxy.rs | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/devices/src/proxy.rs b/devices/src/proxy.rs index a91d2ed..e7cc95f 100644 --- a/devices/src/proxy.rs +++ b/devices/src/proxy.rs @@ -6,10 +6,11 @@ use libc::pid_t; +use std::fmt::{self, Display}; use std::os::unix::io::{AsRawFd, RawFd}; use std::process; use std::time::Duration; -use std::{self, fmt, io}; +use std::{self, io}; use io_jail::{self, Minijail}; use msg_socket::{MsgOnSocket, MsgReceiver, MsgSender, MsgSocket}; @@ -25,11 +26,13 @@ pub enum Error { } pub type Result<T> = std::result::Result<T, Error>; -impl fmt::Display for Error { +impl Display for Error { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + use self::Error::*; + match self { - Error::ForkingJail(_) => write!(f, "Failed to fork jail process"), - Error::Io(e) => write!(f, "IO error configuring proxy device {}.", e), + ForkingJail(e) => write!(f, "Failed to fork jail process: {}", e), + Io(e) => write!(f, "IO error configuring proxy device {}.", e), } } } |