summary refs log tree commit diff
diff options
context:
space:
mode:
authorDavid Tolnay <dtolnay@chromium.org>2018-11-29 15:33:22 -0800
committerchrome-bot <chrome-bot@chromium.org>2018-12-02 00:05:35 -0800
commit21fb34fb937678d85e9bfa4c721ab4a29196c764 (patch)
tree9ad6e24f71a7f79c179baf01451a77444e134a08
parentb14ce22a1bab381d94be94b67c756ad7dc908f8b (diff)
downloadcrosvm-21fb34fb937678d85e9bfa4c721ab4a29196c764.tar
crosvm-21fb34fb937678d85e9bfa4c721ab4a29196c764.tar.gz
crosvm-21fb34fb937678d85e9bfa4c721ab4a29196c764.tar.bz2
crosvm-21fb34fb937678d85e9bfa4c721ab4a29196c764.tar.lz
crosvm-21fb34fb937678d85e9bfa4c721ab4a29196c764.tar.xz
crosvm-21fb34fb937678d85e9bfa4c721ab4a29196c764.tar.zst
crosvm-21fb34fb937678d85e9bfa4c721ab4a29196c764.zip
devices: Remove duplicated doc comments in impl block
These duplicate the doc comments found in `trait PciDevice`. I am
removing them because a sensible reader would already assume that they
have fallen out of sync with the doc comments in the trait, and thus
refer to the trait definition anyway.

TEST=none

Change-Id: Id86936a6f2a1b6c78a000b107bb4fc8ed78e40f9
Reviewed-on: https://chromium-review.googlesource.com/1355350
Commit-Ready: David Tolnay <dtolnay@chromium.org>
Tested-by: David Tolnay <dtolnay@chromium.org>
Reviewed-by: Jingkui Wang <jkwang@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
-rw-r--r--devices/src/pci/pci_device.rs12
1 files changed, 0 insertions, 12 deletions
diff --git a/devices/src/pci/pci_device.rs b/devices/src/pci/pci_device.rs
index 275d8d3..e5132d1 100644
--- a/devices/src/pci/pci_device.rs
+++ b/devices/src/pci/pci_device.rs
@@ -108,33 +108,21 @@ impl<T: PciDevice + ?Sized> PciDevice for Box<T> {
     ) {
         (**self).assign_irq(irq_evt, irq_resample_evt, irq_num, irq_pin)
     }
-    /// Allocates the needed IO BAR space using the `allocate` function which takes a size and
-    /// returns an address. Returns a Vec of (address, length) tuples.
     fn allocate_io_bars(&mut self, resources: &mut SystemAllocator) -> Result<Vec<(u64, u64)>> {
         (**self).allocate_io_bars(resources)
     }
-    /// Gets a list of ioeventfds that should be registered with the running VM. The list is
-    /// returned as a Vec of (eventfd, addr, datamatch) tuples.
     fn ioeventfds(&self) -> Vec<(&EventFd, u64, Datamatch)> {
         (**self).ioeventfds()
     }
-    /// Gets the configuration registers of the Pci Device.
     fn config_registers(&self) -> &PciConfiguration {
         (**self).config_registers()
     }
-    /// Gets the configuration registers of the Pci Device for modification.
     fn config_registers_mut(&mut self) -> &mut PciConfiguration {
         (**self).config_registers_mut()
     }
-    /// Reads from a BAR region mapped in to the device.
-    /// * `addr` - The guest address inside the BAR.
-    /// * `data` - Filled with the data from `addr`.
     fn read_bar(&mut self, addr: u64, data: &mut [u8]) {
         (**self).read_bar(addr, data)
     }
-    /// Writes to a BAR region mapped in to the device.
-    /// * `addr` - The guest address inside the BAR.
-    /// * `data` - The data to write.
     fn write_bar(&mut self, addr: u64, data: &[u8]) {
         (**self).write_bar(addr, data)
     }