diff options
| author | Doron Behar <doron.behar@gmail.com> | 2020-12-09 20:19:06 +0000 |
|---|---|---|
| committer | Doron Behar <doron.behar@gmail.com> | 2020-12-09 23:24:02 +0200 |
| commit | e8360685cb0dce9c46d4fb18dd13f36c8b518837 (patch) | |
| tree | 404a4a555f05d937e5c494465c3d358eb0da53c0 | |
| parent | c2756603f5f1714b9f06dcca218f9a19a4654da9 (diff) | |
| download | nixpkgs-e8360685cb0dce9c46d4fb18dd13f36c8b518837.tar nixpkgs-e8360685cb0dce9c46d4fb18dd13f36c8b518837.tar.gz nixpkgs-e8360685cb0dce9c46d4fb18dd13f36c8b518837.tar.bz2 nixpkgs-e8360685cb0dce9c46d4fb18dd13f36c8b518837.tar.lz nixpkgs-e8360685cb0dce9c46d4fb18dd13f36c8b518837.tar.xz nixpkgs-e8360685cb0dce9c46d4fb18dd13f36c8b518837.tar.zst nixpkgs-e8360685cb0dce9c46d4fb18dd13f36c8b518837.zip | |
STALE-BOT.md: Mention github not notifying
Following https://discourse.nixos.org/t/github-doesnt-notify-reviewers-commenters-after-you-force-push-changes/10394 .
| -rw-r--r-- | .github/STALE-BOT.md | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/.github/STALE-BOT.md b/.github/STALE-BOT.md index 3b1599baebf..7b3f013710a 100644 --- a/.github/STALE-BOT.md +++ b/.github/STALE-BOT.md @@ -7,11 +7,12 @@ ## Suggestions for PRs -1. If it is unfinished but you plan to finish it, please mark it as a draft. -2. If you don't expect to work on it any time soon, closing it with a short comment may encourage someone else to pick up your work. -3. To get things rolling again, rebase the PR against the target branch and address valid comments. -4. If you need a review to move forward, ask in [the Discourse thread for PRs that need help](https://discourse.nixos.org/t/prs-in-distress/3604). -5. If all you need is a merge, check the git history to find and [request reviews](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review) from people who usually merge related contributions. +1. GitHub sometimes doesn't notify people who commented / reviewed a PR previously, when you (force) push commits. If you have addressed the reviews you can [officially ask for a review](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review) from those who commented to you or anyone else. +2. If it is unfinished but you plan to finish it, please mark it as a draft. +3. If you don't expect to work on it any time soon, closing it with a short comment may encourage someone else to pick up your work. +4. To get things rolling again, rebase the PR against the target branch and address valid comments. +5. If you need a review to move forward, ask in [the Discourse thread for PRs that need help](https://discourse.nixos.org/t/prs-in-distress/3604). +6. If all you need is a merge, check the git history to find and [request reviews](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review) from people who usually merge related contributions. ## Suggestions for issues |