summary refs log tree commit diff
diff options
context:
space:
mode:
authorsternenseemann <sternenseemann@systemli.org>2022-03-20 11:05:56 +0100
committersternenseemann <sternenseemann@systemli.org>2022-03-20 11:09:38 +0100
commitcd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3 (patch)
tree0254e79fc9cbfaec7537ebbfd22c39fdb2f40a73
parent22ced213c00d26d3337815221ee5ab1e38f15bff (diff)
downloadnixpkgs-cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3.tar
nixpkgs-cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3.tar.gz
nixpkgs-cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3.tar.bz2
nixpkgs-cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3.tar.lz
nixpkgs-cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3.tar.xz
nixpkgs-cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3.tar.zst
nixpkgs-cd0ddefb4382e26c8f8f7bd0acd2c18b2fae94c3.zip
maintainers/haskell/update-stackage.sh: make shellcheck happy
* Annotate shell type
* Make trap expansion safer
-rwxr-xr-xmaintainers/scripts/haskell/update-stackage.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/maintainers/scripts/haskell/update-stackage.sh b/maintainers/scripts/haskell/update-stackage.sh
index c5f9f19c6fd..0c41b4eec58 100755
--- a/maintainers/scripts/haskell/update-stackage.sh
+++ b/maintainers/scripts/haskell/update-stackage.sh
@@ -1,5 +1,6 @@
 #! /usr/bin/env nix-shell
 #! nix-shell -i bash -p nix curl jq nix-prefetch-github git gnused gnugrep -I nixpkgs=.
+# shellcheck shell=bash
 
 set -eu -o pipefail
 
@@ -13,11 +14,10 @@ toLower() {
 }
 
 tmpfile=$(mktemp "update-stackage.XXXXXXX")
-# shellcheck disable=SC2064
 
 stackage_config="pkgs/development/haskell-modules/configuration-hackage2nix/stackage.yaml"
 
-trap "rm ${tmpfile} ${tmpfile}.new" 0
+trap 'rm "${tmpfile}" "${tmpfile}.new"' 0
 touch "$tmpfile" "$tmpfile.new" # Creating files here so that trap creates no errors.
 
 curl -L -s "https://stackage.org/$(toLower "$SOLVER")/cabal.config" >"$tmpfile"