summary refs log tree commit diff
diff options
context:
space:
mode:
authorSandro <sandro.jaeckel@gmail.com>2023-07-19 15:22:52 +0200
committerGitHub <noreply@github.com>2023-07-19 15:22:52 +0200
commitc7ba59e48506b6f4ba471a9bf0c67f607b771bde (patch)
tree8d6c0dc239a2fa1d2cda8c30c980604c9a1e663d
parent1c664aebd8afd84a1c66cb57c975c9f10156529b (diff)
parente59046bc48bd57a15b99b92be55520af4923f5c3 (diff)
downloadnixpkgs-c7ba59e48506b6f4ba471a9bf0c67f607b771bde.tar
nixpkgs-c7ba59e48506b6f4ba471a9bf0c67f607b771bde.tar.gz
nixpkgs-c7ba59e48506b6f4ba471a9bf0c67f607b771bde.tar.bz2
nixpkgs-c7ba59e48506b6f4ba471a9bf0c67f607b771bde.tar.lz
nixpkgs-c7ba59e48506b6f4ba471a9bf0c67f607b771bde.tar.xz
nixpkgs-c7ba59e48506b6f4ba471a9bf0c67f607b771bde.tar.zst
nixpkgs-c7ba59e48506b6f4ba471a9bf0c67f607b771bde.zip
Merge pull request #217565 from winterqt/bootstrapped-pip-remove-extraneous-pythonpath-entry
-rw-r--r--pkgs/development/python-modules/bootstrapped-pip/default.nix7
-rw-r--r--pkgs/development/python2-modules/bootstrapped-pip/default.nix7
2 files changed, 8 insertions, 6 deletions
diff --git a/pkgs/development/python-modules/bootstrapped-pip/default.nix b/pkgs/development/python-modules/bootstrapped-pip/default.nix
index a83cfc02849..2c24fe51deb 100644
--- a/pkgs/development/python-modules/bootstrapped-pip/default.nix
+++ b/pkgs/development/python-modules/bootstrapped-pip/default.nix
@@ -38,9 +38,10 @@ stdenv.mkDerivation rec {
     mv pip* pip
     mv setuptools* setuptools
     mv wheel* wheel
-    # Set up PYTHONPATH. The above folders need to be on PYTHONPATH
-    # $out is where we are installing to and takes precedence
-    export PYTHONPATH="$out/${python.sitePackages}:$(pwd)/pip/src:$(pwd)/setuptools:$(pwd)/setuptools/pkg_resources:$(pwd)/wheel:$PYTHONPATH"
+    # Set up PYTHONPATH:
+    # - pip and setuptools need to be in PYTHONPATH to install setuptools, wheel, and pip.
+    # - $out is where we are installing to and takes precedence, and is where wheel will end so we can install pip.
+    export PYTHONPATH="$out/${python.sitePackages}:$(pwd)/pip/src:$(pwd)/setuptools:$(pwd)/setuptools/pkg_resources:$PYTHONPATH"
 
     echo "Building setuptools wheel..."
     pushd setuptools
diff --git a/pkgs/development/python2-modules/bootstrapped-pip/default.nix b/pkgs/development/python2-modules/bootstrapped-pip/default.nix
index 2fc8b8b8d4b..314bf0048c8 100644
--- a/pkgs/development/python2-modules/bootstrapped-pip/default.nix
+++ b/pkgs/development/python2-modules/bootstrapped-pip/default.nix
@@ -38,9 +38,10 @@ stdenv.mkDerivation rec {
     mv pip* pip
     mv setuptools* setuptools
     mv wheel* wheel
-    # Set up PYTHONPATH. The above folders need to be on PYTHONPATH
-    # $out is where we are installing to and takes precedence
-    export PYTHONPATH="$out/${python.sitePackages}:$(pwd)/pip/src:$(pwd)/setuptools:$(pwd)/setuptools/pkg_resources:$(pwd)/wheel:$PYTHONPATH"
+    # Set up PYTHONPATH:
+    # - pip and setuptools need to be in PYTHONPATH to install setuptools, wheel, and pip.
+    # - $out is where we are installing to and takes precedence, and is where wheel will end so we can install pip.
+    export PYTHONPATH="$out/${python.sitePackages}:$(pwd)/pip/src:$(pwd)/setuptools:$(pwd)/setuptools/pkg_resources:$PYTHONPATH"
 
     echo "Building setuptools wheel..."
     pushd setuptools