summary refs log tree commit diff
diff options
context:
space:
mode:
authorVladimír Čunát <v@cunat.cz>2022-11-08 11:07:29 +0100
committerVladimír Čunát <v@cunat.cz>2022-11-08 11:07:29 +0100
commitc35a930454f97d7fe134c71a7ffa75faa1d89aea (patch)
tree7f98b146d9c67802d6c799d327b03ae89aa3ef57
parent7e3e9bb62070b30b15ab393229be929c4a86b8b7 (diff)
downloadnixpkgs-c35a930454f97d7fe134c71a7ffa75faa1d89aea.tar
nixpkgs-c35a930454f97d7fe134c71a7ffa75faa1d89aea.tar.gz
nixpkgs-c35a930454f97d7fe134c71a7ffa75faa1d89aea.tar.bz2
nixpkgs-c35a930454f97d7fe134c71a7ffa75faa1d89aea.tar.lz
nixpkgs-c35a930454f97d7fe134c71a7ffa75faa1d89aea.tar.xz
nixpkgs-c35a930454f97d7fe134c71a7ffa75faa1d89aea.tar.zst
nixpkgs-c35a930454f97d7fe134c71a7ffa75faa1d89aea.zip
libvirt-glib: fixup build after glib update
I see only one instance of the warning where *equality* of strings
is tested and char signedness differs.  That one seems perfectly safe.
```
../libvirt-gconfig/libvirt-gconfig-domain-capabilities-os.c: In function 'search_firmwares':
../libvirt-gconfig/libvirt-gconfig-domain-capabilities-os.c:70:26: warning: pointer targets in passing argument 1 of 'strcmp' differ in signedness [-Wpointer-sign]
   70 |     if (!g_str_equal(node->name, "enum"))
/nix/store/fmqcm52w0p5jmzdbjjskwjiwyj9kqic9-glib-2.74.1-dev/include/glib-2.0/glib/ghash.h:165:39: note: in definition of macro 'g_str_equal'
  165 | #define g_str_equal(v1, v2) (strcmp ((v1), (v2)) == 0)
      |                                       ^~
```
-rw-r--r--pkgs/development/libraries/libvirt-glib/default.nix3
1 files changed, 3 insertions, 0 deletions
diff --git a/pkgs/development/libraries/libvirt-glib/default.nix b/pkgs/development/libraries/libvirt-glib/default.nix
index b7efdf2cf7d..8f84cd0eab8 100644
--- a/pkgs/development/libraries/libvirt-glib/default.nix
+++ b/pkgs/development/libraries/libvirt-glib/default.nix
@@ -55,6 +55,9 @@ stdenv.mkDerivation rec {
 
   strictDeps = true;
 
+  # https://gitlab.com/libvirt/libvirt-glib/-/issues/4
+  NIX_CFLAGS_COMPILE = [ "-Wno-error=pointer-sign" ];
+
   meta = with lib; {
     description = "Library for working with virtual machines";
     longDescription = ''