summary refs log tree commit diff
diff options
context:
space:
mode:
authorDmitry Kalinkin <dmitry.kalinkin@gmail.com>2020-01-10 16:14:11 -0500
committerGitHub <noreply@github.com>2020-01-10 16:14:11 -0500
commitb74c26a17f1856735577c29d92939721d542f0f5 (patch)
treecbbb6f537ee691e78b8c87d5a38522cf515c1db2
parent41e06190bb3dbe644d1bb1673c9359579bf706fe (diff)
parentef1a86592bc00e92ac783791eadfcde1632e3fe8 (diff)
downloadnixpkgs-b74c26a17f1856735577c29d92939721d542f0f5.tar
nixpkgs-b74c26a17f1856735577c29d92939721d542f0f5.tar.gz
nixpkgs-b74c26a17f1856735577c29d92939721d542f0f5.tar.bz2
nixpkgs-b74c26a17f1856735577c29d92939721d542f0f5.tar.lz
nixpkgs-b74c26a17f1856735577c29d92939721d542f0f5.tar.xz
nixpkgs-b74c26a17f1856735577c29d92939721d542f0f5.tar.zst
nixpkgs-b74c26a17f1856735577c29d92939721d542f0f5.zip
Merge pull request #77467 from veprbl/pr/thrift_darwin_fix
thrift: fix checkPhase on darwin
-rw-r--r--pkgs/development/libraries/thrift/default.nix15
1 files changed, 13 insertions, 2 deletions
diff --git a/pkgs/development/libraries/thrift/default.nix b/pkgs/development/libraries/thrift/default.nix
index b1b66ed052f..1879cac96c1 100644
--- a/pkgs/development/libraries/thrift/default.nix
+++ b/pkgs/development/libraries/thrift/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchurl, boost, zlib, libevent, openssl, python, cmake, pkgconfig
+{ stdenv, fetchurl, fetchpatch, boost, zlib, libevent, openssl, python, cmake, pkgconfig
 , bison, flex, twisted, static ? false }:
 
 stdenv.mkDerivation rec {
@@ -10,6 +10,15 @@ stdenv.mkDerivation rec {
     sha256 = "0yai9c3bdsrkkjshgim7zk0i7malwfprg00l9774dbrkh2w4ilvs";
   };
 
+  patches = [
+    # Fix a failing test on darwin
+    # https://issues.apache.org/jira/browse/THRIFT-4976
+    (fetchpatch {
+      url = "https://github.com/apache/thrift/commit/6701dbb8e89f6550c7843e9b75b118998df471c3.diff";
+      sha256 = "14rqma2b2zv3zxkkl5iv9kvyp3zihvad6fdc2gcdqv37nqnswx9d";
+    })
+  ];
+
   # Workaround to make the python wrapper not drop this package:
   # pythonFull.buildEnv.override { extraLibs = [ thrift ]; }
   pythonPath = [];
@@ -32,7 +41,9 @@ stdenv.mkDerivation rec {
   doCheck = !static;
   checkPhase = ''
     runHook preCheck
-    LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$PWD/lib ctest -E PythonTestSSLSocket
+
+    ${stdenv.lib.optionalString stdenv.isDarwin "DY"}LD_LIBRARY_PATH=$PWD/lib ctest -E PythonTestSSLSocket
+
     runHook postCheck
   '';
   enableParallelChecking = false;