summary refs log tree commit diff
diff options
context:
space:
mode:
authordevhell <^@regexmail.net>2015-10-26 17:36:50 +0000
committerdevhell <^@regexmail.net>2015-10-26 17:36:50 +0000
commitb2e3c05c4879cdef9e98e80bcd768c98f2704105 (patch)
treeb922e6500ca500433ee1de79160c41aa1ce29370
parent6e9f77dc29b76ac80de3b3a06c7347dc9f8c657f (diff)
downloadnixpkgs-b2e3c05c4879cdef9e98e80bcd768c98f2704105.tar
nixpkgs-b2e3c05c4879cdef9e98e80bcd768c98f2704105.tar.gz
nixpkgs-b2e3c05c4879cdef9e98e80bcd768c98f2704105.tar.bz2
nixpkgs-b2e3c05c4879cdef9e98e80bcd768c98f2704105.tar.lz
nixpkgs-b2e3c05c4879cdef9e98e80bcd768c98f2704105.tar.xz
nixpkgs-b2e3c05c4879cdef9e98e80bcd768c98f2704105.tar.zst
nixpkgs-b2e3c05c4879cdef9e98e80bcd768c98f2704105.zip
mp3val: Better installPhase
As mentioned by @aszlig, it's more elegant and sane to use coreutils'
`install`. This commit also changes `platforms` to `unix` since this
should also compile on Darwin for example.
-rw-r--r--pkgs/applications/audio/mp3val/default.nix5
1 files changed, 2 insertions, 3 deletions
diff --git a/pkgs/applications/audio/mp3val/default.nix b/pkgs/applications/audio/mp3val/default.nix
index 76aaeaf8e6b..0957420b658 100644
--- a/pkgs/applications/audio/mp3val/default.nix
+++ b/pkgs/applications/audio/mp3val/default.nix
@@ -12,8 +12,7 @@ stdenv.mkDerivation rec {
   makefile = "Makefile.linux";
 
   installPhase = ''
-    mkdir -p $out/bin/
-    cp mp3val $out/bin/
+    install -Dv mp3val "$out/bin/mp3val"
   '';
 
   meta = {
@@ -30,7 +29,7 @@ stdenv.mkDerivation rec {
     '';
     homepage = http://mp3val.sourceforge.net/index.shtml;
     license = stdenv.lib.licenses.gpl2;
-    platforms = stdenv.lib.platforms.linux;
+    platforms = stdenv.lib.platforms.unix;
     maintainers = [ stdenv.lib.maintainers.devhell ];
   };
 }