summary refs log tree commit diff
diff options
context:
space:
mode:
authorFelix Scheinost <fesc@symentis.com>2021-12-07 14:13:50 +0100
committerFelix Scheinost <fesc@symentis.com>2021-12-07 14:13:50 +0100
commita7483c5a9a5c58039352927ffc76a09fc094a801 (patch)
tree81bdfe540e007981ca73d248738071e52c837f17
parent437c59043212720db6fdb6afc68a2316df6810e8 (diff)
downloadnixpkgs-a7483c5a9a5c58039352927ffc76a09fc094a801.tar
nixpkgs-a7483c5a9a5c58039352927ffc76a09fc094a801.tar.gz
nixpkgs-a7483c5a9a5c58039352927ffc76a09fc094a801.tar.bz2
nixpkgs-a7483c5a9a5c58039352927ffc76a09fc094a801.tar.lz
nixpkgs-a7483c5a9a5c58039352927ffc76a09fc094a801.tar.xz
nixpkgs-a7483c5a9a5c58039352927ffc76a09fc094a801.tar.zst
nixpkgs-a7483c5a9a5c58039352927ffc76a09fc094a801.zip
selenium-server-standalone: fix useChrome = false
Previously when useChrome was set to false the command would be something like

```
makeWrapper [...] \
  --add-flags "-cp [...]" \
  --add-flags  \
  --add-flags "org.openqa.grid.selenium.GridLauncherV3"
```

The problem was that only the arguments to `--add-flags` was optional while for this to be parsed correctly the flag and argument has to be optional.
-rw-r--r--pkgs/development/tools/selenium/server/default.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkgs/development/tools/selenium/server/default.nix b/pkgs/development/tools/selenium/server/default.nix
index c4f8653794f..61959b98b4c 100644
--- a/pkgs/development/tools/selenium/server/default.nix
+++ b/pkgs/development/tools/selenium/server/default.nix
@@ -26,7 +26,7 @@ in stdenv.mkDerivation rec {
     cp $src $out/share/lib/${pname}-${version}/${pname}-${version}.jar
     makeWrapper ${jre}/bin/java $out/bin/selenium-server \
       --add-flags "-cp $out/share/lib/${pname}-${version}/${pname}-${version}.jar:${htmlunit-driver}/share/lib/${htmlunit-driver.name}/${htmlunit-driver.name}.jar" \
-      --add-flags ${optionalString chromeSupport "-Dwebdriver.chrome.driver=${chromedriver}/bin/chromedriver"} \
+      ${optionalString chromeSupport "--add-flags -Dwebdriver.chrome.driver=${chromedriver}/bin/chromedriver"} \
       --add-flags "org.openqa.grid.selenium.GridLauncherV3"
   '';