summary refs log tree commit diff
diff options
context:
space:
mode:
authorSergei Trofimovich <slyich@gmail.com>2022-05-22 14:52:30 +0100
committerSergei Trofimovich <slyich@gmail.com>2022-05-22 14:53:05 +0100
commita35a56895415dc46b514ba30d9445f1800d9f72b (patch)
treea1296a9e1b844f781affc380c18af13791821478
parente04ca593173bc086a1fa195258090aaab9279f1f (diff)
downloadnixpkgs-a35a56895415dc46b514ba30d9445f1800d9f72b.tar
nixpkgs-a35a56895415dc46b514ba30d9445f1800d9f72b.tar.gz
nixpkgs-a35a56895415dc46b514ba30d9445f1800d9f72b.tar.bz2
nixpkgs-a35a56895415dc46b514ba30d9445f1800d9f72b.tar.lz
nixpkgs-a35a56895415dc46b514ba30d9445f1800d9f72b.tar.xz
nixpkgs-a35a56895415dc46b514ba30d9445f1800d9f72b.tar.zst
nixpkgs-a35a56895415dc46b514ba30d9445f1800d9f72b.zip
mpg321: add -fcommon workaround
Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

    ld: volume.o:/build/mpg321-0.3.2-orig/mpg321.h:119: multiple definition of
      `loop_remaining'; mpg321.o:/build/mpg321-0.3.2-orig/mpg321.h:119: first defined here
-rw-r--r--pkgs/applications/audio/mpg321/default.nix6
1 files changed, 6 insertions, 0 deletions
diff --git a/pkgs/applications/audio/mpg321/default.nix b/pkgs/applications/audio/mpg321/default.nix
index 03aee52f2a9..0272d3299cf 100644
--- a/pkgs/applications/audio/mpg321/default.nix
+++ b/pkgs/applications/audio/mpg321/default.nix
@@ -23,6 +23,12 @@ stdenv.mkDerivation rec {
 
   hardeningDisable = [ "format" ];
 
+  # Workaround build failure on -fno-common toolchains like upstream
+  # gcc-10. Otherwise build fails as:
+  #   ld: volume.o:/build/mpg321-0.3.2-orig/mpg321.h:119: multiple definition of
+  #     `loop_remaining'; mpg321.o:/build/mpg321-0.3.2-orig/mpg321.h:119: first defined here
+  NIX_CFLAGS_COMPILE = "-fcommon";
+
   configureFlags =
     [ ("--enable-alsa=" + (if stdenv.isLinux then "yes" else "no")) ]
     ++ (lib.optional (defaultAudio != null)