summary refs log tree commit diff
diff options
context:
space:
mode:
authorSergei Trofimovich <slyich@gmail.com>2023-01-30 22:19:21 +0000
committerSergei Trofimovich <slyich@gmail.com>2023-01-31 18:30:30 +0000
commit726597c1a7d8bae7db3c065b2de6cfb148210452 (patch)
tree1ce4fe7b0f1e8174c06439776c73db6331dd9eca
parente86b3bbf2c88046e6d81efbca00fea0b3143e557 (diff)
downloadnixpkgs-726597c1a7d8bae7db3c065b2de6cfb148210452.tar
nixpkgs-726597c1a7d8bae7db3c065b2de6cfb148210452.tar.gz
nixpkgs-726597c1a7d8bae7db3c065b2de6cfb148210452.tar.bz2
nixpkgs-726597c1a7d8bae7db3c065b2de6cfb148210452.tar.lz
nixpkgs-726597c1a7d8bae7db3c065b2de6cfb148210452.tar.xz
nixpkgs-726597c1a7d8bae7db3c065b2de6cfb148210452.tar.zst
nixpkgs-726597c1a7d8bae7db3c065b2de6cfb148210452.zip
binutils: re-enable plugins support for wasi target
binutils plugins API does not depend on target. It depends only on host.
Tested the change to still be able to compile `firefox` which uses wasi
target and pulls in llvm with binutils plugin support.
-rw-r--r--pkgs/development/tools/misc/binutils/default.nix6
1 files changed, 4 insertions, 2 deletions
diff --git a/pkgs/development/tools/misc/binutils/default.nix b/pkgs/development/tools/misc/binutils/default.nix
index 1028422869e..b352410e213 100644
--- a/pkgs/development/tools/misc/binutils/default.nix
+++ b/pkgs/development/tools/misc/binutils/default.nix
@@ -243,8 +243,10 @@ stdenv.mkDerivation (finalAttrs: {
     inherit targetPrefix;
     hasGold = enableGold;
     isGNU = true;
-    # Having --enable-plugins is not enough, system has to support dlopen()
-    hasPluginAPI = enableGold && !stdenv.isDarwin && !stdenv.targetPlatform.isWasi;
+    # Having --enable-plugins is not enough, system has to support
+    # dlopen() or equivalent. See config/plugins.m4 and configure.ac
+    # (around PLUGINS) for cases that support or not support plugins.
+    hasPluginAPI = enableGold && !stdenv.isDarwin;
   };
 
   meta = with lib; {