summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndré Vitor de Lima Matos <andre.vmatos@gmail.com>2022-04-26 15:33:03 +0000
committerAndré Vitor de Lima Matos <andre.vmatos@gmail.com>2022-04-26 12:42:13 -0300
commit5223d2c13b7705b54430026df3ea432ef3256984 (patch)
tree4ff3d62134cf609d602c31521a41b4771c907734
parent69b03815604f684b45372797d14d08a35bb7a1a9 (diff)
downloadnixpkgs-5223d2c13b7705b54430026df3ea432ef3256984.tar
nixpkgs-5223d2c13b7705b54430026df3ea432ef3256984.tar.gz
nixpkgs-5223d2c13b7705b54430026df3ea432ef3256984.tar.bz2
nixpkgs-5223d2c13b7705b54430026df3ea432ef3256984.tar.lz
nixpkgs-5223d2c13b7705b54430026df3ea432ef3256984.tar.xz
nixpkgs-5223d2c13b7705b54430026df3ea432ef3256984.tar.zst
nixpkgs-5223d2c13b7705b54430026df3ea432ef3256984.zip
kde/gear: apply suggestions from code review
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
-rw-r--r--pkgs/applications/kde/kaddressbook.nix1
-rw-r--r--pkgs/development/libraries/mimetic/default.nix2
2 files changed, 2 insertions, 1 deletions
diff --git a/pkgs/applications/kde/kaddressbook.nix b/pkgs/applications/kde/kaddressbook.nix
index 4ab0721de1a..6080ad5db34 100644
--- a/pkgs/applications/kde/kaddressbook.nix
+++ b/pkgs/applications/kde/kaddressbook.nix
@@ -22,6 +22,7 @@ mkDerivation {
     kxmlgui libkdepim libkleo mailcommon pimcommon prison qgpgme qtbase
   ];
   postInstall = ''
+    # added as an include directory by cmake files and fails to compile if it's missing
     mkdir -p "$out/include/KF5"
   '';
 }
diff --git a/pkgs/development/libraries/mimetic/default.nix b/pkgs/development/libraries/mimetic/default.nix
index 839643887c0..5a965c3d7d9 100644
--- a/pkgs/development/libraries/mimetic/default.nix
+++ b/pkgs/development/libraries/mimetic/default.nix
@@ -17,7 +17,7 @@ stdenv.mkDerivation rec {
       url = "https://github.com/tat/mimetic/commit/bf84940f9021950c80846e6b1a5f8b0b55991b00.patch";
       sha256 = "sha256-1JW9zPg67BgNsdIjK/jp9j7QMg50eRMz5FsDsbbzBlI=";
     })
-  ] ++ lib.optional stdenv.isAarch64 [ ./narrowing.patch ];
+  ] ++ lib.optional stdenv.isAarch64 ./narrowing.patch;
 
   meta = with lib; {
     description = "MIME handling library";