summary refs log tree commit diff
diff options
context:
space:
mode:
authorEelco Dolstra <edolstra@gmail.com>2021-06-03 19:01:09 +0200
committerEelco Dolstra <edolstra@gmail.com>2021-06-03 19:01:09 +0200
commit4cffb1212a0c80a8e856d508a0a7eea5f1d43736 (patch)
tree54f1c6de45bbde51a653d3e9199ef968f02dc5b8
parent53bc86a9ad2bbeb80f7dcace209b4ca9e01f0e98 (diff)
downloadnixpkgs-4cffb1212a0c80a8e856d508a0a7eea5f1d43736.tar
nixpkgs-4cffb1212a0c80a8e856d508a0a7eea5f1d43736.tar.gz
nixpkgs-4cffb1212a0c80a8e856d508a0a7eea5f1d43736.tar.bz2
nixpkgs-4cffb1212a0c80a8e856d508a0a7eea5f1d43736.tar.lz
nixpkgs-4cffb1212a0c80a8e856d508a0a7eea5f1d43736.tar.xz
nixpkgs-4cffb1212a0c80a8e856d508a0a7eea5f1d43736.tar.zst
nixpkgs-4cffb1212a0c80a8e856d508a0a7eea5f1d43736.zip
nixos-rebuild --fast: Don't imply --show-trace
There is no logical reason for --fast to imply --show-trace, and this
seems to be a historical accident. Using --show-trace by default is
bad UX since it can give very long error messages (e.g. 550 lines for
a non-existent attribute in environment.systemPackages).
-rw-r--r--nixos/doc/manual/man-nixos-rebuild.xml7
-rw-r--r--pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh1
2 files changed, 3 insertions, 5 deletions
diff --git a/nixos/doc/manual/man-nixos-rebuild.xml b/nixos/doc/manual/man-nixos-rebuild.xml
index d0ff81c1dbb..a5ea81bcdab 100644
--- a/nixos/doc/manual/man-nixos-rebuild.xml
+++ b/nixos/doc/manual/man-nixos-rebuild.xml
@@ -402,10 +402,9 @@
     </term>
     <listitem>
      <para>
-      Equivalent to <option>--no-build-nix</option>
-      <option>--show-trace</option>. This option is useful if you call
-      <command>nixos-rebuild</command> frequently (e.g. if you’re hacking on
-      a NixOS module).
+      Equivalent to <option>--no-build-nix</option>. This option is
+      useful if you call <command>nixos-rebuild</command> frequently
+      (e.g. if you’re hacking on a NixOS module).
      </para>
     </listitem>
    </varlistentry>
diff --git a/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh b/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh
index 087afb5b6a6..02614aea6d0 100644
--- a/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh
+++ b/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh
@@ -79,7 +79,6 @@ while [ "$#" -gt 0 ]; do
       --fast)
         buildNix=
         fast=1
-        extraBuildFlags+=(--show-trace)
         ;;
       --profile-name|-p)
         if [ -z "$1" ]; then