summary refs log tree commit diff
diff options
context:
space:
mode:
authorSergei Trofimovich <slyich@gmail.com>2022-05-28 21:22:48 +0100
committerSergei Trofimovich <slyich@gmail.com>2022-05-28 21:23:07 +0100
commit49f2c94e0c078afe58627a39c3f2149f68bedaaa (patch)
tree9e4c16e6a487a68990daf7039a324e567dcfc793
parent0831857a140328c5c40be233eaa73130620a44b2 (diff)
downloadnixpkgs-49f2c94e0c078afe58627a39c3f2149f68bedaaa.tar
nixpkgs-49f2c94e0c078afe58627a39c3f2149f68bedaaa.tar.gz
nixpkgs-49f2c94e0c078afe58627a39c3f2149f68bedaaa.tar.bz2
nixpkgs-49f2c94e0c078afe58627a39c3f2149f68bedaaa.tar.lz
nixpkgs-49f2c94e0c078afe58627a39c3f2149f68bedaaa.tar.xz
nixpkgs-49f2c94e0c078afe58627a39c3f2149f68bedaaa.tar.zst
nixpkgs-49f2c94e0c078afe58627a39c3f2149f68bedaaa.zip
rockbox-utility: add -fcommon workaround
Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

    ld: libmkimxboot.a(elf.c.o):utils/imxtools/sbtools/misc.h:43: multiple definition of `g_nr_keys';
      libmkimxboot.a(mkimxboot.c.o):utils/imxtools/sbtools/misc.h:43: first defined here
-rw-r--r--pkgs/tools/misc/rockbox-utility/default.nix7
1 files changed, 7 insertions, 0 deletions
diff --git a/pkgs/tools/misc/rockbox-utility/default.nix b/pkgs/tools/misc/rockbox-utility/default.nix
index bf191beca3f..2ca7478b742 100644
--- a/pkgs/tools/misc/rockbox-utility/default.nix
+++ b/pkgs/tools/misc/rockbox-utility/default.nix
@@ -43,6 +43,13 @@ stdenv.mkDerivation  rec {
     lrelease rbutilqt.pro
   '';
 
+  # Workaround build failure on -fno-common toolchains like upstream
+  # gcc-10. Otherwise build fails as:
+  #   ld: libmkimxboot.a(elf.c.o):utils/imxtools/sbtools/misc.h:43: multiple definition of `g_nr_keys';
+  #     libmkimxboot.a(mkimxboot.c.o):utils/imxtools/sbtools/misc.h:43: first defined here
+  # TODO: try to remove with 1.5.1 update.
+  NIX_CFLAGS_COMPILE = "-fcommon";
+
   installPhase = ''
     runHook preInstall