summary refs log tree commit diff
diff options
context:
space:
mode:
authoraaron levin <aaron.levin@soundcloud.com>2015-12-16 23:26:07 +0100
committeraaron levin <aaron.levin@soundcloud.com>2015-12-16 23:34:36 +0100
commit3b3be7a74b8bd46711f04b88bbfab37ed325332d (patch)
tree2c24441146fd48bc76b44c465c7d34cb758a4360
parentfd45c7b82b65c31a5be7854d8566260b781c6d6b (diff)
downloadnixpkgs-3b3be7a74b8bd46711f04b88bbfab37ed325332d.tar
nixpkgs-3b3be7a74b8bd46711f04b88bbfab37ed325332d.tar.gz
nixpkgs-3b3be7a74b8bd46711f04b88bbfab37ed325332d.tar.bz2
nixpkgs-3b3be7a74b8bd46711f04b88bbfab37ed325332d.tar.lz
nixpkgs-3b3be7a74b8bd46711f04b88bbfab37ed325332d.tar.xz
nixpkgs-3b3be7a74b8bd46711f04b88bbfab37ed325332d.tar.zst
nixpkgs-3b3be7a74b8bd46711f04b88bbfab37ed325332d.zip
link_power_policy_management default to max_performance
The kernel default for `link_power_management_policy` is `"max_performance"`.
This commit:
https://github.com/NixOS/nixpkgs/commit/f169f60575bec7c61626af180cae364d321b4bec
set the NixOS default to `"min_performance"`.

This issue (https://github.com/NixOS/nixpkgs/issues/11276) details my long
journey to discover this after several file system failures incorrectly
attributed to `TRIM` and `NCQ` settings.

I think we should use the kernel default of `"max_performance"` to assure
the best experience for new users with SSDs and to conform to the defaults of
the kernel and other distros.
-rw-r--r--nixos/modules/config/power-management.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/nixos/modules/config/power-management.nix b/nixos/modules/config/power-management.nix
index dedc8a3f679..6086f06ca3d 100644
--- a/nixos/modules/config/power-management.nix
+++ b/nixos/modules/config/power-management.nix
@@ -71,7 +71,7 @@ in
 
     # FIXME: Implement powersave governor for sandy bridge or later Intel CPUs
     powerManagement.cpuFreqGovernor = mkDefault "ondemand";
-    powerManagement.scsiLinkPolicy = mkDefault "min_power";
+    powerManagement.scsiLinkPolicy = mkDefault "max_performance";
 
     systemd.targets.post-resume = {
       description = "Post-Resume Actions";