diff options
| author | Winter <winter@winter.cafe> | 2023-02-25 22:24:56 -0500 |
|---|---|---|
| committer | Winter <winter@winter.cafe> | 2023-02-25 22:31:56 -0500 |
| commit | 15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db (patch) | |
| tree | c9d67e471ac015ff0c773f141b8b12556b17b964 | |
| parent | 0f487f2b51f2cede265bd1f83cc1548d3d788b3d (diff) | |
| download | nixpkgs-15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db.tar nixpkgs-15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db.tar.gz nixpkgs-15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db.tar.bz2 nixpkgs-15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db.tar.lz nixpkgs-15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db.tar.xz nixpkgs-15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db.tar.zst nixpkgs-15f1369b95d04a90fcb4ac1e5e59f2d2dfe154db.zip | |
Revert "nixos/systemd-coredump: guard static gid for systemd-coredump behind state version"
This reverts commits f5483464d5726d05b6169017e6b0f64ebccc2f53 and 6b9583e5e121b26468d880bdb65302a9172fc041. Ideally, we shouldn't cause friction for users that bump `stateVersion`, and I'd consider having to switch and/or manually hardcode a UID/GID to supress the warning friction. I think it'd be more beneficial to, in this rare case of an ID being missed, just let it be until more discussion happens surrounding this overall issue. See https://github.com/NixOS/nixpkgs/pull/217785 for more context.
| -rw-r--r-- | nixos/modules/misc/ids.nix | 1 | ||||
| -rw-r--r-- | nixos/modules/system/boot/systemd/coredump.nix | 4 |
2 files changed, 1 insertions, 4 deletions
diff --git a/nixos/modules/misc/ids.nix b/nixos/modules/misc/ids.nix index 108ab5d4f31..deeed10d014 100644 --- a/nixos/modules/misc/ids.nix +++ b/nixos/modules/misc/ids.nix @@ -510,7 +510,6 @@ in #seeks = 148; # removed 2020-06-21 prosody = 149; i2pd = 150; - systemd-coredump = 151; systemd-network = 152; systemd-resolve = 153; systemd-timesync = 154; diff --git a/nixos/modules/system/boot/systemd/coredump.nix b/nixos/modules/system/boot/systemd/coredump.nix index deaaba9bbf8..03ef00e5683 100644 --- a/nixos/modules/system/boot/systemd/coredump.nix +++ b/nixos/modules/system/boot/systemd/coredump.nix @@ -66,9 +66,7 @@ in { uid = config.ids.uids.systemd-coredump; group = "systemd-coredump"; }; - users.groups.systemd-coredump = { - gid = mkIf (lib.versionAtLeast config.system.stateVersion "23.05") config.ids.gids.systemd-coredump; - }; + users.groups.systemd-coredump = {}; }) (mkIf (!cfg.enable) { |