diff options
author | Dylan Reid <dgreid@chromium.org> | 2019-03-07 14:18:03 -0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-12 18:54:14 -0700 |
commit | 8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe (patch) | |
tree | 3a8676f11c221b96d6d30de852ab99eb5a50fda2 | |
parent | 39133a0fd580497647c3920d79bd73bb3175fb0d (diff) | |
download | crosvm-8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe.tar crosvm-8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe.tar.gz crosvm-8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe.tar.bz2 crosvm-8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe.tar.lz crosvm-8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe.tar.xz crosvm-8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe.tar.zst crosvm-8d7f4ac63cb345fe5d84600e3b75f2d1b46ebbbe.zip |
sys_util: guest_address: take self by value in methods
clippy says that it is more efficient. Since self is a u64 in this case, it is correct. Signed-off-by: Dylan Reid <dgreid@chromium.org> Change-Id: Id7674db500a01640f650b239374fe9f83e2bc595 Reviewed-on: https://chromium-review.googlesource.com/1510065 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org>
-rw-r--r-- | sys_util/src/guest_address.rs | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/sys_util/src/guest_address.rs b/sys_util/src/guest_address.rs index 3e521ff..1b78e71 100644 --- a/sys_util/src/guest_address.rs +++ b/sys_util/src/guest_address.rs @@ -23,34 +23,34 @@ impl GuestAddress { /// let addr = GuestAddress(0x150); /// assert_eq!(addr.offset_from(base), 0x50u64); /// ``` - pub fn offset_from(&self, base: GuestAddress) -> u64 { + pub fn offset_from(self, base: GuestAddress) -> u64 { self.0 - base.0 } /// Returns the address as a u64 offset from 0x0. /// Use this when a raw number is needed to pass to the kernel. - pub fn offset(&self) -> u64 { + pub fn offset(self) -> u64 { self.0 } /// Returns the result of the add or None if there is overflow. - pub fn checked_add(&self, other: u64) -> Option<GuestAddress> { + pub fn checked_add(self, other: u64) -> Option<GuestAddress> { self.0.checked_add(other).map(GuestAddress) } /// Returns the result of the base address + the size. /// Only use this when `offset` is guaranteed not to overflow. - pub fn unchecked_add(&self, offset: u64) -> GuestAddress { + pub fn unchecked_add(self, offset: u64) -> GuestAddress { GuestAddress(self.0 + offset) } /// Returns the result of the subtraction of None if there is underflow. - pub fn checked_sub(&self, other: u64) -> Option<GuestAddress> { + pub fn checked_sub(self, other: u64) -> Option<GuestAddress> { self.0.checked_sub(other).map(GuestAddress) } /// Returns the bitwise and of the address with the given mask. - pub fn mask(&self, mask: u64) -> GuestAddress { + pub fn mask(self, mask: u64) -> GuestAddress { GuestAddress(self.0 & mask as u64) } } |