[PATCH nixpkgs] chromiumOSPackages.libqmi: don't enable doc twice
This is already enabled in the original derivation, so overriding it to add it here just means we end up passing the option twice. --- pkgs/os-specific/linux/chromium-os/libqmi/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix index b96b5224b57..7328642d0b4 100644 --- a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix +++ b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix @@ -15,7 +15,7 @@ libqmi.overrideAttrs ( # ModemManager tests fail with QRTR in Chromium OS 91. # Will hopefully be fixed in CrOS 92. - configureFlags = configureFlags ++ [ "--enable-gtk-doc" "--disable-qrtr" ]; + configureFlags = configureFlags ++ [ "--disable-qrtr" ]; passthru = passthru // { updateScript = ../update.py; -- 2.32.0
On Thu Aug 12, 2021 at 2:31 AM PDT, Alyssa Ross wrote:
This is already enabled in the original derivation, so overriding it to add it here just means we end up passing the option twice. --- pkgs/os-specific/linux/chromium-os/libqmi/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix index b96b5224b57..7328642d0b4 100644 --- a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix +++ b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix @@ -15,7 +15,7 @@ libqmi.overrideAttrs (
# ModemManager tests fail with QRTR in Chromium OS 91. # Will hopefully be fixed in CrOS 92. - configureFlags = configureFlags ++ [ "--enable-gtk-doc" "--disable-qrtr" ]; + configureFlags = configureFlags ++ [ "--disable-qrtr" ];
passthru = passthru // { updateScript = ../update.py; -- 2.32.0
But what if we want twice the amount of documentation?
Joking aside, LGTM.
Reviewed-by: Cole Helbling
"Cole Helbling"
On Thu Aug 12, 2021 at 2:31 AM PDT, Alyssa Ross wrote:
This is already enabled in the original derivation, so overriding it to add it here just means we end up passing the option twice. --- pkgs/os-specific/linux/chromium-os/libqmi/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix index b96b5224b57..7328642d0b4 100644 --- a/pkgs/os-specific/linux/chromium-os/libqmi/default.nix +++ b/pkgs/os-specific/linux/chromium-os/libqmi/default.nix @@ -15,7 +15,7 @@ libqmi.overrideAttrs (
# ModemManager tests fail with QRTR in Chromium OS 91. # Will hopefully be fixed in CrOS 92. - configureFlags = configureFlags ++ [ "--enable-gtk-doc" "--disable-qrtr" ]; + configureFlags = configureFlags ++ [ "--disable-qrtr" ];
passthru = passthru // { updateScript = ../update.py; -- 2.32.0
But what if we want twice the amount of documentation?
Joking aside, LGTM.
Reviewed-by: Cole Helbling
Thanks for the review! Pushed as cec682e0071.
participants (2)
-
Alyssa Ross -
Cole Helbling