[PATCH ucspi-vsock] Makefile: stop repeating program list
Using a wildcard with rm -f means that if there are no object files to remove, rm will try to remove a non-existent file named '*.c', and then ignore the failure it gets by trying to do that. Which is fine. --- Makefile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 1a4bb10..2045cdd 100644 --- a/Makefile +++ b/Makefile @@ -10,12 +10,14 @@ INSTALL_PROGRAM = $(INSTALL) prefix = /usr/local bindir = $(prefix)/bin -all: vsockclient vsockserver +PROGRAMS = vsockclient vsockserver + +all: $(PROGRAMS) .PHONY: all -install: vsockclient vsockserver +install: $(PROGRAMS) mkdir -p $(DESTDIR)$(bindir) - $(INSTALL_PROGRAM) vsockclient vsockserver $(DESTDIR)$(bindir) + $(INSTALL_PROGRAM) $(PROGRAMS) $(DESTDIR)$(bindir) .PHONY: install vsockclient: vsockclient.o env.o log.o num.o vsock.o @@ -27,6 +29,5 @@ vsockclient.o: env.h log.h num.h vsock.h vsockserver.o: env.h log.h num.h vsock.h clean: - rm -f env.o log.o num.o vsock.o \ - vsockclient.o vsockclient vsockserver.o vsockserver + rm -f $(PROGRAMS) *.o .PHONY: clean -- 2.30.0
On Wed Mar 17, 2021 at 5:36 PM PDT, Alyssa Ross wrote:
Using a wildcard with rm -f means that if there are no object files to remove, rm will try to remove a non-existent file named '*.c', and
Nit: do you mean '*.o'? ;)
then ignore the failure it gets by trying to do that. Which is fine. --- Makefile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Using a wildcard with rm -f means that if there are no object files to remove, rm will try to remove a non-existent file named '*.c', and
Nit: do you mean '*.o'? ;)
Oh, yes I do. I'll just fix that up locally without sending a new patch.
then ignore the failure it gets by trying to do that. Which is fine. --- Makefile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Look good otherwise? :)
On Thu Mar 18, 2021 at 5:57 AM PDT, Alyssa Ross wrote:
Using a wildcard with rm -f means that if there are no object files to remove, rm will try to remove a non-existent file named '*.c', and
Nit: do you mean '*.o'? ;)
Oh, yes I do. I'll just fix that up locally without sending a new patch.
then ignore the failure it gets by trying to do that. Which is fine. --- Makefile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Look good otherwise? :)
Yes indeed!
Reviewed-by: Cole Helbling
Using a wildcard with rm -f means that if there are no object files to remove, rm will try to remove a non-existent file named '*.c', and
Nit: do you mean '*.o'? ;)
Oh, yes I do. I'll just fix that up locally without sending a new patch.
then ignore the failure it gets by trying to do that. Which is fine. --- Makefile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
Look good otherwise? :)
Yes indeed!
Reviewed-by: Cole Helbling
Thanks! Committed as f55c634.
participants (2)
-
Alyssa Ross
-
Cole Helbling